[keba] Improve connection establishment and stability #10179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Weger <weger.michael@gmx.net>
fwolter
requested changes
Feb 18, 2021
...b.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactHandler.java
Outdated
Show resolved
Hide resolved
...b.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactHandler.java
Outdated
Show resolved
Hide resolved
- introduced QuantityTypes - removed redundant pwmpilotcurrent (duplicate of maxpilotcurrent) - added maxpilotcurrentdutycyle Signed-off-by: Michael Weger <weger.michael@gmx.net>
|
@fwolter, thanks for the review! it includes the following additional refactoring of the binding:
I hope it is OK to have this now in the same PR |
Signed-off-by: Michael Weger <weger.michael@gmx.net>
|
@fwolter, my latest commit should resolve all your recent comments |
fwolter
requested changes
Feb 22, 2021
...b.binding.keba/src/main/java/org/openhab/binding/keba/internal/handler/KeContactHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.keba/src/main/resources/OH-INF/thing/kecontact.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.keba/src/main/resources/OH-INF/thing/kecontact.xml
Show resolved
Hide resolved
fwolter
added
(potentially) not backward compatible
and removed
bug
Signed-off-by: Michael Weger <weger.michael@gmx.net>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
Signed-off-by: Michael Weger <weger.michael@gmx.net> * - worked in review findings - introduced QuantityTypes - removed redundant pwmpilotcurrent (duplicate of maxpilotcurrent) - added maxpilotcurrentdutycyle Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
Signed-off-by: Michael Weger <weger.michael@gmx.net> * - worked in review findings - introduced QuantityTypes - removed redundant pwmpilotcurrent (duplicate of maxpilotcurrent) - added maxpilotcurrentdutycyle
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Michael Weger <weger.michael@gmx.net> * - worked in review findings - introduced QuantityTypes - removed redundant pwmpilotcurrent (duplicate of maxpilotcurrent) - added maxpilotcurrentdutycyle
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Michael Weger <weger.michael@gmx.net> * - worked in review findings - introduced QuantityTypes - removed redundant pwmpilotcurrent (duplicate of maxpilotcurrent) - added maxpilotcurrentdutycyle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Weger weger.michael@gmx.net
My second try of a pull request for the changes discussed in #6347 (comment)
I had some troubles with my first pull requst #10151 and therefore deleted it.
I still have the problem, that parts of this pull request have been developed by @Raketenschnitzel and I do not know how to reach out to him in order to ask for his approval.
He might reply to this conversation, as he is mentioned ...
All other problems from the first PR should be resolved.
[keba] Improve connection establishment and stability
Binding for testing: