Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] additional vacuum channels for advanced rules #10180

Merged
merged 3 commits into from
Feb 25, 2021

Conversation

marcelrv
Copy link
Contributor

closes #10144

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added the enhancement An enhancement or new feature for an existing add-on label Feb 16, 2021
@marcelrv marcelrv changed the title Miio vacuum room [miio] additional vacuum channels for advanced rules Feb 16, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/cleaning-specific-room-and-zones-with-multi-level-map-roborock/115329/19

@cpmeister
Copy link
Contributor

Can you update the readme to reflect the new channels?

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv
Copy link
Contributor Author

Can you update the readme to reflect the new channels?

Yes, done.

| ambientBrightness | Number | Ambient Brightness | |
| ambientBrightness | Dimmer | Ambient Brightness | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this change have to do with this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing,
It seems this was missed in the previous run, so it was picked up in the new run

@cpmeister cpmeister merged commit d1d42c4 into openhab:main Feb 25, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 25, 2021
@marcelrv marcelrv deleted the miio-vacuum-room branch February 26, 2021 09:41
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
* [miio] add feature channels
* [miio] additional vacuum channels for advanced rules
* [miio] update readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
* [miio] add feature channels
* [miio] additional vacuum channels for advanced rules
* [miio] update readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* [miio] add feature channels
* [miio] additional vacuum channels for advanced rules
* [miio] update readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [miio] add feature channels
* [miio] additional vacuum channels for advanced rules
* [miio] update readme

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miio] add channel for room16 in order to find current floor
3 participants