Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] add support for deerma Humidifier #10181

Merged
merged 9 commits into from
Feb 25, 2021

Conversation

marcelrv
Copy link
Contributor

close #10173
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added enhancement An enhancement or new feature for an existing add-on work in progress A PR that is not yet ready to be merged labels Feb 16, 2021
@marcelrv marcelrv changed the title [miio] deerma Humidifier [miio] add support for deerma Humidifier Feb 16, 2021
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv removed the work in progress A PR that is not yet ready to be merged label Feb 21, 2021
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@theater
Copy link
Contributor

theater commented Feb 25, 2021

Tested it and looks good from feature perspective

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 6d2211a into openhab:main Feb 25, 2021
@cpmeister cpmeister added this to the 3.1 milestone Feb 25, 2021
@marcelrv marcelrv deleted the miio-deerma-humidifier branch February 26, 2021 09:41
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
* [miio] deerma Humidifier

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
* [miio] deerma Humidifier

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* [miio] deerma Humidifier

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [miio] deerma Humidifier

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miio] Add support for Xiaomi MiSmart Antibacterial Humidifier (deerma.humidifier.jsq)
3 participants