-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[openwebnet] add support for Energy Meter #10191
Conversation
sync with official repo
Signed-off-by: Andrea Conte <andrea@conte.com> Signed-off-by: Conte Andrea <andrea@conte.com>
ac3d640
to
0a89dc5
Compare
this PR will also close #10242 by using version 0.4.0 of the openwebnet4j lib (see: https://github.com/mvalla/openwebnet4j/releases/tag/0.4.0). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you modify the images intentionally?
...ding.openwebnet/src/main/java/org/openhab/binding/openwebnet/OpenWebNetBindingConstants.java
Show resolved
Hide resolved
...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetBridgeHandler.java
Show resolved
Hide resolved
...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java
Outdated
Show resolved
Hide resolved
...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java
Outdated
Show resolved
Hide resolved
...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java
Outdated
Show resolved
Hide resolved
...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java
Outdated
Show resolved
Hide resolved
...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/BusEnergyMeter.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.openwebnet/src/main/resources/OH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
update code to 14/03
Signed-off-by: Conte Andrea <andrea@conte.com>
Signed-off-by: Conte Andrea <andrea@conte.com>
...openwebnet/src/main/java/org/openhab/binding/openwebnet/handler/OpenWebNetEnergyHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Conte Andrea <andrea@conte.com>
@mvalla The 0.4.0 version is not found when building this PR. |
@fwolter Very strange: actually all versions of the lib are now returning "403 Fobidden". Maybe it's a temporary problem, hopefully not related to the soon to be Bintray/JCenter shutdown |
It is related to it. I have started working on openhab/openhab-distro#1256 and this requires us to not use any dependencies from JCenter anymore. @mvalla Could you publish the lib to Maven Central instead? This seems to be the only working option on the long run. |
it looks like a double problem.
Did you have similar problems with other artifacts used by OH and not available anymore? |
Yes, I have similar problems with other artifacts and I am looking for an alternative source for each. If none can be found, I temporarily upload them to our Artifactory. I just did so with openwebnet4j as well, but I uses |
@@ -23,7 +23,7 @@ | |||
<dependency> | |||
<groupId>com.github.openwebnet4j</groupId> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<groupId>com.github.openwebnet4j</groupId> | |
<groupId>openwebnet4j</groupId> |
This should make it resolve from our Artifactory for now.
Thanks @kaikreuzer for hosting the artifact on OH Artifactory : it's a shame JCenter apparently is offline even before the planned date!
Actually the policy is:
that is why I used So to summarize: I will move to Maven Central keeping |
If you read carefully, it says that the groupId must be |
@mvalla I have uploaded version 0.4.0 to our Artifactory under the current groupId, so that it can now be resolved. |
thanks @kaikreuzer for publishing under OH Artifactory with the current groupId: that is indeed the cleanest temporary solution. I leave to @aconte80 the fixes for the spotless errors. |
Ah, right, I didn't notice that this PR wasn't from you :-) |
Signed-off-by: Conte Andrea <andrea@conte.com>
11239c1
to
824a939
Compare
@kaikreuzer @fwolter I've fixed the spotless error. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thank you all!
They are linked now @mvalla. :-) |
Signed-off-by: Andrea Conte <andrea@conte.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
Signed-off-by: Andrea Conte <andrea@conte.com>
Signed-off-by: Andrea Conte <andrea@conte.com>
Signed-off-by: Andrea Conte <andrea@conte.com>
These changes will:
Fixes #10188
Fixes #10242