Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[homematic] Additional check for convert to double #10207

Merged
merged 1 commit into from
Mar 13, 2021
Merged

Conversation

Piwoxar
Copy link
Contributor

@Piwoxar Piwoxar commented Feb 21, 2021

In the homematic ccu I can create system variables of type enum.
In method parse() of class CcuVariablesAndScriptsParser the attributes entry.minValue and entry.maxValue contains in this case "" and "" can't be converted to a double. So an exception was raise.

With this additional check the exception doesn't occurs anymore.

@MHerbst
Copy link
Contributor

MHerbst commented Feb 21, 2021

Your proposed change looks OK, but you need to sign your commit.

@fwolter
Copy link
Member

fwolter commented Mar 13, 2021

You need to sign-off your commits. See https://www.openhab.org/docs/developer/contributing.html#sign-your-work The necessary commands are listed when you click on "Details" at the DCO check below.

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, applying the small patch exception.

@fwolter fwolter merged commit 04d4caa into openhab:main Mar 13, 2021
@fwolter fwolter added this to the 3.1 milestone Mar 13, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
Co-authored-by: Hans-Dieter <hdloew@freenet.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Co-authored-by: Hans-Dieter <hdloew@freenet.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Co-authored-by: Hans-Dieter <hdloew@freenet.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 9, 2022
Co-authored-by: Hans-Dieter <hdloew@freenet.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 16, 2022
Co-authored-by: Hans-Dieter <hdloew@freenet.de>
Signed-off-by: Marc Fischer <marc.fischer2@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants