[homekit] extend support of flag "inverted" to other accessories #10212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugen Freiter <freiter@gmx.de>
yfre
changed the title
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/homekit-contactsensor-inverted/117625/6 |
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…ab#10212) Signed-off-by: Eugen Freiter <freiter@gmx.de> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…ab#10212) Signed-off-by: Eugen Freiter <freiter@gmx.de>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…ab#10212) Signed-off-by: Eugen Freiter <freiter@gmx.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…ab#10212) Signed-off-by: Eugen Freiter <freiter@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support of "inverted" flag to further accessories. flag "inverted" swap the mapping from Switch and Contact states to corresponding states of HomeKit accessories. This could be useful as the states of physical devices are not always correspond to HomeKit accessories states, e.g
https://community.openhab.org/t/openhab-3-0-1-invert-locks-homekit/117093/9
https://community.openhab.org/t/homekit-contactsensor-inverted/117625/5
this flag was already available for few accessories like Lock or WindowCovering. this PR add it to all Switch and Contact accessories.
this PR does not change the existing behaviour as flag "inverted" is optional
Signed-off-by: Eugen Freiter freiter@gmx.de