Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chromecast] Added play URL actions to chromecast binding #10245

Merged
merged 2 commits into from
Mar 14, 2021

Conversation

computergeek1507
Copy link
Contributor

Added play URL actions to chromecast binding. URL and mimeType can be passed to the chromecast binding.

Signed-off-by: Scott Hanson scooter_seh@yahoo.com (github: computergeek1507)

@computergeek1507 computergeek1507 added the enhancement An enhancement or new feature for an existing add-on label Feb 26, 2021
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaikreuzer Do you want to take another look, as the code owner? 135 lines

@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Mar 14, 2021
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer added this to the 3.1 milestone Mar 14, 2021
@kaikreuzer kaikreuzer merged commit 5f1dd38 into openhab:main Mar 14, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
)

* Added play url actions to chromeCast binding

Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 added a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
)

* Added play url actions to chromeCast binding

Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
@computergeek1507 computergeek1507 deleted the chromecast_action branch July 13, 2021 13:29
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
)

* Added play url actions to chromeCast binding

Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
)

* Added play url actions to chromeCast binding

Signed-off-by: Scott Hanson <scooter_seh@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants