[epsonprojector] Fix ONLINE status reporting #10266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
cpmeister
requested changes
Mar 2, 2021
Comment on lines
162
to
164
| if (state != UnDefType.UNDEF && getThing().getStatus() != ThingStatus.ONLINE) { | ||
| updateStatus(ThingStatus.ONLINE); | ||
| } |
There was a problem hiding this comment.
Generally I think the thing should go online prior to any status updates, but that might just be a preference since I'm not aware of any documentation dictating that it must be done that way.
Another thing worth mentioning is that you don't need to check the existing thing status before updating it since that will automatically be checked by the updateStatus implementation.
Suggested change
| if (state != UnDefType.UNDEF && getThing().getStatus() != ThingStatus.ONLINE) { | |
| updateStatus(ThingStatus.ONLINE); | |
| } | |
| if (state != UnDefType.UNDEF) { | |
| updateStatus(ThingStatus.ONLINE); | |
| } |
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
cpmeister
approved these changes
Mar 2, 2021
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
* Epsonprojector - Fix ONLINE status reporting * review changes Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
* Epsonprojector - Fix ONLINE status reporting * review changes Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* Epsonprojector - Fix ONLINE status reporting * review changes Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Epsonprojector - Fix ONLINE status reporting * review changes Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue with the Epson projector binding reporting the thing status as ONLINE even when no valid responses were being received. When connecting the binding to a serial port that generated any response, the thing would show as being ONLINE. The fix checks for valid responses and will only switch the thing to ONLINE when a valid response is received.