Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nikohomecontrol] Add shutter invert and fix connection with NHC does not recover #10281

Merged
merged 8 commits into from
Mar 13, 2021
Merged

[nikohomecontrol] Add shutter invert and fix connection with NHC does not recover #10281

merged 8 commits into from
Mar 13, 2021

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Mar 5, 2021 •
edited
Loading

@mherwege
Ignore devices.changed event.
a21c637 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Null warnings cleanup.
aee721e 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Remove @NonNullByDefault({})
bd763c0 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Shorten logger messages.
2f6f64c 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Introduce rollershutter invert flag.
5681d98 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Add null annotations.
f3d3856 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
@mherwege
Connection resilience improvements and log level cleanup.
c73fd55 
Signed-off-by: Mark Herwege <mark.herwege@telenet.be>
fwolter
fwolter approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the tiny code improvements, LGTM!

bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@fwolter
Update bundles/org.openhab.binding.nikohomecontrol/src/main/resources…
355368f 
…/OH-INF/thing/thing-types.xml


Signed-off-by: Fabian Wolter <github@fabian-wolter.de>
@fwolter fwolter merged commit 286bced into openhab:main Mar 13, 2021
@fwolter fwolter changed the title [nikohomecontrol] Improvements and fixes #10263 [nikohomecontrol] Add shutter invert and fix connection with NHC does not recover Mar 13, 2021
@fwolter fwolter added this to the 3.1 milestone Mar 13, 2021
@fwolter fwolter added bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on labels Mar 13, 2021
arjanmels pushed a commit to arjanmels/openhab2-addons that referenced this pull request Mar 14, 2021
@mherwege @fwolter
[nikohomecontrol] Add shutter invert and fix connection with NHC does…
18ccada 
… not recover (openhab#10281)

* Ignore devices.changed event.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Null warnings cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Remove @NonNullByDefault({})

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Shorten logger messages.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Introduce rollershutter invert flag.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Add null annotations.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Connection resilience improvements and log level cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Update bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@mherwege @fwolter @themillhousegroup
[nikohomecontrol] Add shutter invert and fix connection with NHC does…
5bfeeeb 
… not recover (openhab#10281)

* Ignore devices.changed event.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Null warnings cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Remove @NonNullByDefault({})

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Shorten logger messages.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Introduce rollershutter invert flag.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Add null annotations.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Connection resilience improvements and log level cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Update bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@mherwege @fwolter @computergeek1507
[nikohomecontrol] Add shutter invert and fix connection with NHC does…
08871bb 
… not recover (openhab#10281)

* Ignore devices.changed event.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Null warnings cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Remove @NonNullByDefault({})

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Shorten logger messages.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Introduce rollershutter invert flag.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Add null annotations.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Connection resilience improvements and log level cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Update bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@mherwege @fwolter @thinkingstone
[nikohomecontrol] Add shutter invert and fix connection with NHC does…
3d912d4 
… not recover (openhab#10281)

* Ignore devices.changed event.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Null warnings cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Remove @NonNullByDefault({})

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Shorten logger messages.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Introduce rollershutter invert flag.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Add null annotations.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Connection resilience improvements and log level cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Update bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@mherwege @fwolter
[nikohomecontrol] Add shutter invert and fix connection with NHC does…
a9b00ad 
… not recover (openhab#10281)

* Ignore devices.changed event.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Null warnings cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Remove @NonNullByDefault({})

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Shorten logger messages.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Introduce rollershutter invert flag.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Add null annotations.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Connection resilience improvements and log level cleanup.

Signed-off-by: Mark Herwege <mark.herwege@telenet.be>

* Update bundles/org.openhab.binding.nikohomecontrol/src/main/resources/OH-INF/thing/thing-types.xml

Signed-off-by: Fabian Wolter <github@fabian-wolter.de>

Co-authored-by: Fabian Wolter <github@fabian-wolter.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fwolter fwolter fwolter approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[nikohomecontrol] Connection with NHC does not recover after configuration update
2 participants
@mherwege @fwolter