Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mcp23017] Update Pi4J to 1.4 so binding works with Java 11 #10293

Merged
merged 1 commit into from
Mar 7, 2021
Merged

[mcp23017] Update Pi4J to 1.4 so binding works with Java 11 #10293

merged 1 commit into from
Mar 7, 2021

Conversation

mrumpf
Copy link
Contributor

@mrumpf mrumpf commented Mar 7, 2021

Fixes #9503. The Pi4j version 1.4 introduces Java 11 compatibility
by implementing a missing function as native code and thus dropping
the dependency to the function jdk.internal.misc.SharedSecrets.
See Pi4J/pi4j-v1#442 for details.

Signed-off-by: Michael Rumpf michael@rumpfonline.de

@mrumpf
Fixes openhab#9503 by updating Pi4j to the recently released version …
2910f16 
…1.4.

This version introduces Java 11 compatibility by implementing a missing
function as native code and thus dropping the dependency to the
function jdk.internal.misc.SharedSecrets.
See Pi4J/pi4j-v1#442 for details.

Signed-off-by: Michael Rumpf <michael@rumpfonline.de>
@mrumpf mrumpf requested a review from aogorek as a code owner March 7, 2021 09:58
Hilbrand
Hilbrand approved these changes Mar 7, 2021
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit e9cd6de into openhab:main Mar 7, 2021
@Hilbrand Hilbrand added the bug An unexpected problem or unintended behavior of an add-on label Mar 7, 2021
@Hilbrand Hilbrand added this to the 3.1 milestone Mar 7, 2021
arjanmels pushed a commit to arjanmels/openhab2-addons that referenced this pull request Mar 14, 2021
@mrumpf
[mcp23017] Fixes openhab#9503 by updating Pi4j to the recently releas…
0d438a5 
…ed version 1.4. (openhab#10293)

This version introduces Java 11 compatibility by implementing a missing
function as native code and thus dropping the dependency to the
function jdk.internal.misc.SharedSecrets.
See Pi4J/pi4j-v1#442 for details.

Signed-off-by: Michael Rumpf <michael@rumpfonline.de>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@mrumpf @themillhousegroup
[mcp23017] Fixes openhab#9503 by updating Pi4j to the recently releas…
e69eaee 
…ed version 1.4. (openhab#10293)

This version introduces Java 11 compatibility by implementing a missing
function as native code and thus dropping the dependency to the
function jdk.internal.misc.SharedSecrets.
See Pi4J/pi4j-v1#442 for details.

Signed-off-by: Michael Rumpf <michael@rumpfonline.de>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
@wborn wborn changed the title [mcp32017] Fixes #9503 by updating Pi4j to the recently released version 1.4. [mcp32017] Update Pi4J to 1.4 so binding works with Java 11 Jun 22, 2021
@Hilbrand Hilbrand changed the title [mcp32017] Update Pi4J to 1.4 so binding works with Java 11 [mcp23017] Update Pi4J to 1.4 so binding works with Java 11 Jun 27, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mcp23017-on-openhab-3-0/110992/12

@wborn wborn mentioned this pull request Jun 28, 2021
Closed
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@mrumpf @computergeek1507
[mcp23017] Fixes openhab#9503 by updating Pi4j to the recently releas…
a2454d7 
…ed version 1.4. (openhab#10293)

This version introduces Java 11 compatibility by implementing a missing
function as native code and thus dropping the dependency to the
function jdk.internal.misc.SharedSecrets.
See Pi4J/pi4j-v1#442 for details.

Signed-off-by: Michael Rumpf <michael@rumpfonline.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@mrumpf @thinkingstone
[mcp23017] Fixes openhab#9503 by updating Pi4j to the recently releas…
be8f075 
…ed version 1.4. (openhab#10293)

This version introduces Java 11 compatibility by implementing a missing
function as native code and thus dropping the dependency to the
function jdk.internal.misc.SharedSecrets.
See Pi4J/pi4j-v1#442 for details.

Signed-off-by: Michael Rumpf <michael@rumpfonline.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@mrumpf
[mcp23017] Fixes openhab#9503 by updating Pi4j to the recently releas…
288fa79 
…ed version 1.4. (openhab#10293)

This version introduces Java 11 compatibility by implementing a missing
function as native code and thus dropping the dependency to the
function jdk.internal.misc.SharedSecrets.
See Pi4J/pi4j-v1#442 for details.

Signed-off-by: Michael Rumpf <michael@rumpfonline.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@aogorek aogorek Awaiting requested review from aogorek aogorek is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[mcp23017] pi4j not compatible with Java 11
3 participants
@mrumpf @openhab-bot @Hilbrand