Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oppo] Fix setting verbose mode at startup #10306

Merged
merged 1 commit into from
Mar 13, 2021

Conversation

mlobstein
Copy link
Contributor

@mlobstein mlobstein commented Mar 9, 2021

Fix the bug identified in issue #10282. These changes improve the polling routine to properly detect when the player power is on or off. If the connection is interrupted the verbose mode will be set again in case the power to the player was interrupted.

Test build here:
https://github.com/mlobstein/mlobstein-beta-test/raw/master/org.openhab.binding.oppo-3.1.0-SNAPSHOT.jar
https://github.com/mlobstein/mlobstein-beta-test/raw/master/org.openhab.binding.oppo-3.1.0-SNAPSHOT-sources.jar

Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter merged commit 493f8c4 into openhab:main Mar 13, 2021
@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Mar 13, 2021
@fwolter fwolter added this to the 3.1 milestone Mar 13, 2021
arjanmels pushed a commit to arjanmels/openhab2-addons that referenced this pull request Mar 14, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
@mlobstein mlobstein deleted the oppo_verbosefix branch March 15, 2021 20:14
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Michael Lobstein <michael.lobstein@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants