Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lifx] Fix all SAT findings #10307

Merged
merged 1 commit into from
Mar 10, 2021
Merged

[lifx] Fix all SAT findings #10307

merged 1 commit into from
Mar 10, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 9, 2021

@wborn
[lifx] Fix all SAT findings
5603b5b 
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested a review from a team March 9, 2021 23:05
kaikreuzer
kaikreuzer approved these changes Mar 10, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup, thanks!

@kaikreuzer kaikreuzer merged commit f3a517e into openhab:main Mar 10, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Mar 10, 2021
@wborn wborn deleted the lifx-fix-sat-findings branch March 10, 2021 09:02
arjanmels pushed a commit to arjanmels/openhab2-addons that referenced this pull request Mar 14, 2021
@wborn
[lifx] Fix all SAT findings (openhab#10307)
a693ccf 
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto

Signed-off-by: Wouter Born <github@maindrain.net>
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@wborn @themillhousegroup
[lifx] Fix all SAT findings (openhab#10307)
44571d5 
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@wborn @computergeek1507
[lifx] Fix all SAT findings (openhab#10307)
4bdb399 
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto

Signed-off-by: Wouter Born <github@maindrain.net>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@wborn @thinkingstone
[lifx] Fix all SAT findings (openhab#10307)
8b082a8 
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto

Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@wborn
[lifx] Fix all SAT findings (openhab#10307)
4245f90 
* Remove dependency on commons-lang classes
* Use HexUtils
* Fix/add missing initial contribution author lines
* Add unit test for MACAddress
* Rename protocol package to dto

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @kaikreuzer