Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework more commons-lang usages #10314

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Rework more commons-lang usages #10314

merged 2 commits into from
Mar 16, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 12, 2021

  • Reworks many commons-lang usages to use standard Java
  • Updates all remaining commons.lang imports to commons.lang3

Related to #7722

@hmerk
Copy link
Contributor

hmerk commented Mar 12, 2021

Why did you make changes to the Wemo binding, there is already a PR for removing apache.commons completely.
We only need to fix the tests, but this is not easy for me, as I did not write those.

@wborn
Copy link
Member Author

wborn commented Mar 12, 2021

That's a good thing @hmerk! I can not remember the details of all PRs. 😉

@wborn wborn mentioned this pull request Mar 12, 2021
Merged
@bobadair
Copy link
Member

LGTM for the Lutron binding.

mhilbush
mhilbush approved these changes Mar 13, 2021
View reviewed changes
Copy link
Contributor

@mhilbush mhilbush left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the following bindings: ambientweather, bigassfan, ecobee, globalcache, weathercompany

Thanks for doing this!

druciak
druciak reviewed Mar 13, 2021
View reviewed changes
Copy link
Member

@druciak druciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why have you done changes to Satel binding? It had already removed all commons dependencies.

...b.binding.satel/src/main/java/org/openhab/binding/satel/internal/command/ControlCommand.java Show resolved Hide resolved
...b.binding.satel/src/main/java/org/openhab/binding/satel/internal/command/ControlCommand.java Show resolved Hide resolved
druciak
druciak approved these changes Mar 13, 2021
View reviewed changes
Copy link
Member

@druciak druciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Satel binding looks good

@wborn
Copy link
Member Author

wborn commented Mar 13, 2021

It showed up in my search for StringUtils usages @druciak. When bindings like Satel prevent null values and use null annotations all those redundant null checks can be skipped and there shouldn't be much use for isEmpty, isBlank etc. provided by utility classes similar to the commons-lang StringUtils.

mherwege
mherwege approved these changes Mar 14, 2021
View reviewed changes
Copy link
Contributor

@mherwege mherwege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the upnpcontrol binding.

wborn added 2 commits March 15, 2021 00:28
@wborn
Rework more commons-lang usages
c89d759 
* Reworks many commons-lang usages to use standard Java
* Updates all remaining commons.lang imports to commons.lang3

Related to openhab#7722

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Remove commons-lang leftovers
2bfe5b7 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the rework-commons-lang branch from 69dc29d to 2bfe5b7 Compare March 14, 2021 23:28
@marcelrv
Copy link
Contributor

LGTM for max binding

@wborn wborn merged commit f350343 into openhab:main Mar 16, 2021
@wborn wborn deleted the rework-commons-lang branch March 16, 2021 11:38
@wborn wborn mentioned this pull request Mar 16, 2021
Open
@wborn wborn added this to the 3.1 milestone Mar 21, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@wborn @themillhousegroup
Rework more commons-lang usages (openhab#10314)
11a4045 
* Reworks many commons-lang usages to use standard Java
* Updates all remaining commons.lang imports to commons.lang3

Related to openhab#7722

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@wborn @computergeek1507
Rework more commons-lang usages (openhab#10314)
5e5259f 
* Reworks many commons-lang usages to use standard Java
* Updates all remaining commons.lang imports to commons.lang3

Related to openhab#7722

Signed-off-by: Wouter Born <github@maindrain.net>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@wborn @thinkingstone
Rework more commons-lang usages (openhab#10314)
ae72c32 
* Reworks many commons-lang usages to use standard Java
* Updates all remaining commons.lang imports to commons.lang3

Related to openhab#7722

Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@wborn
Rework more commons-lang usages (openhab#10314)
f5b1b76 
* Reworks many commons-lang usages to use standard Java
* Updates all remaining commons.lang imports to commons.lang3

Related to openhab#7722

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mherwege mherwege mherwege approved these changes

@mhilbush mhilbush mhilbush approved these changes

@cweitkamp cweitkamp cweitkamp approved these changes

@druciak druciak druciak approved these changes

@9037568 9037568 Awaiting requested review from 9037568 9037568 is a code owner

@alexf2015 alexf2015 Awaiting requested review from alexf2015 alexf2015 is a code owner

@aogorek aogorek Awaiting requested review from aogorek aogorek is a code owner

@bobadair bobadair Awaiting requested review from bobadair bobadair is a code owner

@cdjackson cdjackson Awaiting requested review from cdjackson cdjackson is a code owner

@cpmeister cpmeister Awaiting requested review from cpmeister cpmeister is a code owner

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

@digitaldan digitaldan Awaiting requested review from digitaldan digitaldan is a code owner

@fruggy83 fruggy83 Awaiting requested review from fruggy83 fruggy83 is a code owner

@gedejong gedejong Awaiting requested review from gedejong gedejong is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg

@gnlpfjh gnlpfjh Awaiting requested review from gnlpfjh gnlpfjh is a code owner

@Hilbrand Hilbrand Awaiting requested review from Hilbrand Hilbrand is a code owner

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@jjlauterbach jjlauterbach Awaiting requested review from jjlauterbach jjlauterbach is a code owner

@jsjames jsjames Awaiting requested review from jsjames jsjames is a code owner

@jwveldhuis jwveldhuis Awaiting requested review from jwveldhuis jwveldhuis is a code owner

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

@klocsson klocsson Awaiting requested review from klocsson klocsson is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@Markinus Markinus Awaiting requested review from Markinus Markinus is a code owner

@marvkis marvkis Awaiting requested review from marvkis marvkis is a code owner

@mgbowman mgbowman Awaiting requested review from mgbowman mgbowman is a code owner

@msteigenberger msteigenberger Awaiting requested review from msteigenberger msteigenberger is a code owner

@Nebula83 Nebula83 Awaiting requested review from Nebula83 Nebula83 is a code owner

@octa22 octa22 Awaiting requested review from octa22 octa22 is a code owner

@ollie-dev ollie-dev Awaiting requested review from ollie-dev

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

@paphko paphko Awaiting requested review from paphko paphko is a code owner

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

@pdegeus pdegeus Awaiting requested review from pdegeus

@peuter peuter Awaiting requested review from peuter peuter is a code owner

@reyem reyem Awaiting requested review from reyem reyem is a code owner

@SamuelBrucksch SamuelBrucksch Awaiting requested review from SamuelBrucksch SamuelBrucksch is a code owner

@seime seime Awaiting requested review from seime seime is a code owner

@Stratehm Stratehm Awaiting requested review from Stratehm Stratehm is a code owner

@svilenvul svilenvul Awaiting requested review from svilenvul

@syphr42 syphr42 Awaiting requested review from syphr42 syphr42 is a code owner

@tavalin tavalin Awaiting requested review from tavalin tavalin is a code owner

@tmrobert8 tmrobert8 Awaiting requested review from tmrobert8

@tratho tratho Awaiting requested review from tratho tratho is a code owner

@trokohl trokohl Awaiting requested review from trokohl trokohl is a code owner

@Wire82 Wire82 Awaiting requested review from Wire82 Wire82 is a code owner

@zarusz zarusz Awaiting requested review from zarusz zarusz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
8 participants
@wborn @hmerk @bobadair @marcelrv @druciak @cweitkamp @mhilbush @mherwege