Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[groupepsa] Initial Contribution #10332

Merged
merged 32 commits into from
Apr 30, 2022
Merged

[groupepsa] Initial Contribution #10332

merged 32 commits into from
Apr 30, 2022

Conversation

arjanmels
Copy link
Contributor

New Binding for Groupe PSA (Opel, Peugeot, Citroen, DS, Vauxhall) cars

Binding to retrieve information via the Groupe PSA Web API for cars.

A compiled version is available at: https://github.com/arjanmels/openhab2-addons/releases

Forum thread: https://community.openhab.org/t/new-binding-for-groupe-psa-peugeot-citroen-ds-opel-vauxhall-cars/110580/7

Testing by various forum members has taken place.

@arjanmels arjanmels marked this pull request as ready for review March 14, 2021 15:13
@arjanmels arjanmels requested a review from a team as a code owner March 14, 2021 15:13
@fwolter fwolter added the new binding If someone has started to work on a binding. For a new binding PR. label Mar 14, 2021
@Skinah
Copy link
Contributor

Skinah commented Mar 28, 2021

FYI the channels need to be lowerCamelCase, see here:
https://www.openhab.org/docs/developer/guidelines.html#java-coding-style

@arjanmels
Copy link
Contributor Author

@Skinah Thank you. Corrected in latest update.

Arjan Mels added 4 commits April 25, 2022 15:44
Signed-off-by: Arjan Mels <github@mels.email>
Added dependencies to NOTICE

Signed-off-by: Arjan Mels <github@mels.email>
Signed-off-by: Arjan Mels <github@mels.email>
Signed-off-by: Arjan Mels <github@mels.email>
@arjanmels
Copy link
Contributor Author

@fwolter Finally got round to this binding again. I addressed your suggestions. Looking forward to further review.

@arjanmels arjanmels requested a review from fwolter April 25, 2022 15:32
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html after building it with mvn clean install.

bundles/org.openhab.binding.groupepsa/NOTICE Outdated Show resolved Hide resolved
bundles/org.openhab.binding.groupepsa/README.md Outdated Show resolved Hide resolved
Comment on lines 29 to 30
|clientId||Yes|The client ID for API access: can normally left at the default value. (see: https://developer.groupe-psa.io/webapi/b2c/quickstart/connect/#article)|
|clientSecret||Yes|The client secret for API access: can normally left at the default value. (see: https://developer.groupe-psa.io/webapi/b2c/quickstart/connect/#article)|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure PSA is okay with it, that every openHAB user uses the same credentials to access their API?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the credentials also used by the mobile apps. (Creating individual API keys with the proper permissions is quite an involved process.)

bundles/org.openhab.binding.groupepsa/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.groupepsa/README.md Outdated Show resolved Hide resolved
<item-type>String</item-type>
<label>Ignition</label>
<description>Ignition state</description>
<category>Motion</category>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, but I don't see the relation to the Motion category. This category is more intended for motion or presence detectors.

Signed-off-by: Arjan Mels <github@mels.email>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website

@fwolter fwolter merged commit 8e7c78c into openhab:main Apr 30, 2022
@fwolter fwolter added this to the 3.3 milestone Apr 30, 2022
@arjanmels
Copy link
Contributor Author

Thank you! I just submitted a pull request for the logo.

andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Initial commit: template only

Signed-off-by: Arjan Mels <github@mels.email>

* Initial version

Signed-off-by: Arjan Mels <github@mels.email>

* Minor cleanup after rebase

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected type "peugot" => "peugeot"

Signed-off-by: Arjan Mels <github@mels.email>

* Improved Exception messages
Corrected URL

Signed-off-by: Arjan Mels <github@mels.email>

* Switched from vin to id
Changed nextDelayedTime from ZonedDateTime to Duration
Added vehcile etails and additional info retrieval

Signed-off-by: Arjan Mels <github@mels.email>

* Before rebase

Signed-off-by: Arjan Mels <github@mels.email>

* Various fixes

Signed-off-by: Arjan Mels <github@mels.email>

* Updated tests

Signed-off-by: Arjan Mels <github@mels.email>

* Changed double to BigDecimal to keep accuracy
Added lastupdated channel
Small corrections

Signed-off-by: Arjan Mels <github@mels.email>

* Updated to 3.1.0-SNAPSHOT

Signed-off-by: Arjan Mels <github@mels.email>

* Added README.md

Signed-off-by: Arjan Mels <github@mels.email>

* Changed channels to lowerCamelCase

Signed-off-by: Arjan Mels <github@mels.email>

* Minor corrections

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected lastUpdated in thing-types.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed ToStringbuilder

Signed-off-by: Arjan Mels <github@mels.email>

* corrected capitalization in thing-types.xml and Constants

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected URL for Citroen

Signed-off-by: Arjan Mels <github@mels.email>

* Added groupepsa binding to bom pom.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Updated copyrights

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed CheckStyle warnings

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed check style notifications

Signed-off-by: Arjan Mels <github@mels.email>

* Updated readme

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected capitalization of thing-types.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Updated pom. xml to 3.3.0-SNAPSHOT

Signed-off-by: Arjan Mels <github@mels.email>

* Updated copyright messages

Signed-off-by: Arjan Mels <github@mels.email>

* Various minor cleanups
Cleanup of the README.md
Removed unnecessary license header form the feature.xml file
Various null annotation corrections
Further cleanup of thing-types.xml
Cleanup of groupepsa.properties

Signed-off-by: Arjan Mels <github@mels.email>

* Logging updates

Signed-off-by: Arjan Mels <github@mels.email>

* Updated dependencies
Added dependencies to NOTICE

Signed-off-by: Arjan Mels <github@mels.email>

* Ignore lastposition for isConnected check

Signed-off-by: Arjan Mels <github@mels.email>

* Updated to use ThingHandlerService

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed various review findings

Signed-off-by: Arjan Mels <github@mels.email>

Co-authored-by: Arjan Mels <github@mels.email>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
* Initial commit: template only

Signed-off-by: Arjan Mels <github@mels.email>

* Initial version

Signed-off-by: Arjan Mels <github@mels.email>

* Minor cleanup after rebase

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected type "peugot" => "peugeot"

Signed-off-by: Arjan Mels <github@mels.email>

* Improved Exception messages
Corrected URL

Signed-off-by: Arjan Mels <github@mels.email>

* Switched from vin to id
Changed nextDelayedTime from ZonedDateTime to Duration
Added vehcile etails and additional info retrieval

Signed-off-by: Arjan Mels <github@mels.email>

* Before rebase

Signed-off-by: Arjan Mels <github@mels.email>

* Various fixes

Signed-off-by: Arjan Mels <github@mels.email>

* Updated tests

Signed-off-by: Arjan Mels <github@mels.email>

* Changed double to BigDecimal to keep accuracy
Added lastupdated channel
Small corrections

Signed-off-by: Arjan Mels <github@mels.email>

* Updated to 3.1.0-SNAPSHOT

Signed-off-by: Arjan Mels <github@mels.email>

* Added README.md

Signed-off-by: Arjan Mels <github@mels.email>

* Changed channels to lowerCamelCase

Signed-off-by: Arjan Mels <github@mels.email>

* Minor corrections

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected lastUpdated in thing-types.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed ToStringbuilder

Signed-off-by: Arjan Mels <github@mels.email>

* corrected capitalization in thing-types.xml and Constants

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected URL for Citroen

Signed-off-by: Arjan Mels <github@mels.email>

* Added groupepsa binding to bom pom.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Updated copyrights

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed CheckStyle warnings

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed check style notifications

Signed-off-by: Arjan Mels <github@mels.email>

* Updated readme

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected capitalization of thing-types.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Updated pom. xml to 3.3.0-SNAPSHOT

Signed-off-by: Arjan Mels <github@mels.email>

* Updated copyright messages

Signed-off-by: Arjan Mels <github@mels.email>

* Various minor cleanups
Cleanup of the README.md
Removed unnecessary license header form the feature.xml file
Various null annotation corrections
Further cleanup of thing-types.xml
Cleanup of groupepsa.properties

Signed-off-by: Arjan Mels <github@mels.email>

* Logging updates

Signed-off-by: Arjan Mels <github@mels.email>

* Updated dependencies
Added dependencies to NOTICE

Signed-off-by: Arjan Mels <github@mels.email>

* Ignore lastposition for isConnected check

Signed-off-by: Arjan Mels <github@mels.email>

* Updated to use ThingHandlerService

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed various review findings

Signed-off-by: Arjan Mels <github@mels.email>

Co-authored-by: Arjan Mels <github@mels.email>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
wborn added a commit to wborn/openhab-addons that referenced this pull request Dec 4, 2022
This seems to have been forgotten as part of openhab#10332.

Signed-off-by: Wouter Born <github@maindrain.net>
wborn added a commit to wborn/openhab-addons that referenced this pull request Dec 4, 2022
This seems to have been forgotten as part of openhab#10332.

Signed-off-by: Wouter Born <github@maindrain.net>
lolodomo pushed a commit that referenced this pull request Dec 4, 2022
This seems to have been forgotten as part of #10332.

Signed-off-by: Wouter Born <github@maindrain.net>
morph166955 pushed a commit to morph166955/openhab-addons that referenced this pull request Dec 18, 2022
This seems to have been forgotten as part of openhab#10332.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Dec 24, 2022
This seems to have been forgotten as part of openhab#10332.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
borazslo pushed a commit to borazslo/openhab-mideaac-addon that referenced this pull request Jan 8, 2023
This seems to have been forgotten as part of openhab#10332.

Signed-off-by: Wouter Born <github@maindrain.net>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
* Initial commit: template only

Signed-off-by: Arjan Mels <github@mels.email>

* Initial version

Signed-off-by: Arjan Mels <github@mels.email>

* Minor cleanup after rebase

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected type "peugot" => "peugeot"

Signed-off-by: Arjan Mels <github@mels.email>

* Improved Exception messages
Corrected URL

Signed-off-by: Arjan Mels <github@mels.email>

* Switched from vin to id
Changed nextDelayedTime from ZonedDateTime to Duration
Added vehcile etails and additional info retrieval

Signed-off-by: Arjan Mels <github@mels.email>

* Before rebase

Signed-off-by: Arjan Mels <github@mels.email>

* Various fixes

Signed-off-by: Arjan Mels <github@mels.email>

* Updated tests

Signed-off-by: Arjan Mels <github@mels.email>

* Changed double to BigDecimal to keep accuracy
Added lastupdated channel
Small corrections

Signed-off-by: Arjan Mels <github@mels.email>

* Updated to 3.1.0-SNAPSHOT

Signed-off-by: Arjan Mels <github@mels.email>

* Added README.md

Signed-off-by: Arjan Mels <github@mels.email>

* Changed channels to lowerCamelCase

Signed-off-by: Arjan Mels <github@mels.email>

* Minor corrections

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected lastUpdated in thing-types.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed ToStringbuilder

Signed-off-by: Arjan Mels <github@mels.email>

* corrected capitalization in thing-types.xml and Constants

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected URL for Citroen

Signed-off-by: Arjan Mels <github@mels.email>

* Added groupepsa binding to bom pom.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Updated copyrights

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed CheckStyle warnings

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed check style notifications

Signed-off-by: Arjan Mels <github@mels.email>

* Updated readme

Signed-off-by: Arjan Mels <github@mels.email>

* Corrected capitalization of thing-types.xml

Signed-off-by: Arjan Mels <github@mels.email>

* Updated pom. xml to 3.3.0-SNAPSHOT

Signed-off-by: Arjan Mels <github@mels.email>

* Updated copyright messages

Signed-off-by: Arjan Mels <github@mels.email>

* Various minor cleanups
Cleanup of the README.md
Removed unnecessary license header form the feature.xml file
Various null annotation corrections
Further cleanup of thing-types.xml
Cleanup of groupepsa.properties

Signed-off-by: Arjan Mels <github@mels.email>

* Logging updates

Signed-off-by: Arjan Mels <github@mels.email>

* Updated dependencies
Added dependencies to NOTICE

Signed-off-by: Arjan Mels <github@mels.email>

* Ignore lastposition for isConnected check

Signed-off-by: Arjan Mels <github@mels.email>

* Updated to use ThingHandlerService

Signed-off-by: Arjan Mels <github@mels.email>

* Fixed various review findings

Signed-off-by: Arjan Mels <github@mels.email>

Co-authored-by: Arjan Mels <github@mels.email>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
This seems to have been forgotten as part of openhab#10332.

Signed-off-by: Wouter Born <github@maindrain.net>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
This seems to have been forgotten as part of openhab#10332.

Signed-off-by: Wouter Born <github@maindrain.net>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Jan 6, 2024
This seems to have been forgotten as part of openhab#10332.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants