-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[groupepsa] Initial Contribution #10332
Conversation
FYI the channels need to be lowerCamelCase, see here: |
@Skinah Thank you. Corrected in latest update. |
Signed-off-by: Arjan Mels <github@mels.email>
Added dependencies to NOTICE Signed-off-by: Arjan Mels <github@mels.email>
Signed-off-by: Arjan Mels <github@mels.email>
Signed-off-by: Arjan Mels <github@mels.email>
@fwolter Finally got round to this binding again. I addressed your suggestions. Looking forward to further review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html
after building it with mvn clean install
.
|clientId||Yes|The client ID for API access: can normally left at the default value. (see: https://developer.groupe-psa.io/webapi/b2c/quickstart/connect/#article)| | ||
|clientSecret||Yes|The client secret for API access: can normally left at the default value. (see: https://developer.groupe-psa.io/webapi/b2c/quickstart/connect/#article)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure PSA is okay with it, that every openHAB user uses the same credentials to access their API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the credentials also used by the mobile apps. (Creating individual API keys with the proper permissions is quite an involved process.)
<item-type>String</item-type> | ||
<label>Ignition</label> | ||
<description>Ignition state</description> | ||
<category>Motion</category> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right, but I don't see the relation to the Motion category. This category is more intended for motion or presence detectors.
bundles/org.openhab.binding.groupepsa/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.groupepsa/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.groupepsa/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.groupepsa/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Arjan Mels <github@mels.email>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Now, you could add your binding's logo to the openHAB website. See https://www.openhab.org/docs/developer/bindings/#add-your-binding-s-logo-to-the-openhab-website
Thank you! I just submitted a pull request for the logo. |
* Initial commit: template only Signed-off-by: Arjan Mels <github@mels.email> * Initial version Signed-off-by: Arjan Mels <github@mels.email> * Minor cleanup after rebase Signed-off-by: Arjan Mels <github@mels.email> * Corrected type "peugot" => "peugeot" Signed-off-by: Arjan Mels <github@mels.email> * Improved Exception messages Corrected URL Signed-off-by: Arjan Mels <github@mels.email> * Switched from vin to id Changed nextDelayedTime from ZonedDateTime to Duration Added vehcile etails and additional info retrieval Signed-off-by: Arjan Mels <github@mels.email> * Before rebase Signed-off-by: Arjan Mels <github@mels.email> * Various fixes Signed-off-by: Arjan Mels <github@mels.email> * Updated tests Signed-off-by: Arjan Mels <github@mels.email> * Changed double to BigDecimal to keep accuracy Added lastupdated channel Small corrections Signed-off-by: Arjan Mels <github@mels.email> * Updated to 3.1.0-SNAPSHOT Signed-off-by: Arjan Mels <github@mels.email> * Added README.md Signed-off-by: Arjan Mels <github@mels.email> * Changed channels to lowerCamelCase Signed-off-by: Arjan Mels <github@mels.email> * Minor corrections Signed-off-by: Arjan Mels <github@mels.email> * Corrected lastUpdated in thing-types.xml Signed-off-by: Arjan Mels <github@mels.email> * Fixed ToStringbuilder Signed-off-by: Arjan Mels <github@mels.email> * corrected capitalization in thing-types.xml and Constants Signed-off-by: Arjan Mels <github@mels.email> * Corrected URL for Citroen Signed-off-by: Arjan Mels <github@mels.email> * Added groupepsa binding to bom pom.xml Signed-off-by: Arjan Mels <github@mels.email> * Updated copyrights Signed-off-by: Arjan Mels <github@mels.email> * Fixed CheckStyle warnings Signed-off-by: Arjan Mels <github@mels.email> * Fixed check style notifications Signed-off-by: Arjan Mels <github@mels.email> * Updated readme Signed-off-by: Arjan Mels <github@mels.email> * Corrected capitalization of thing-types.xml Signed-off-by: Arjan Mels <github@mels.email> * Updated pom. xml to 3.3.0-SNAPSHOT Signed-off-by: Arjan Mels <github@mels.email> * Updated copyright messages Signed-off-by: Arjan Mels <github@mels.email> * Various minor cleanups Cleanup of the README.md Removed unnecessary license header form the feature.xml file Various null annotation corrections Further cleanup of thing-types.xml Cleanup of groupepsa.properties Signed-off-by: Arjan Mels <github@mels.email> * Logging updates Signed-off-by: Arjan Mels <github@mels.email> * Updated dependencies Added dependencies to NOTICE Signed-off-by: Arjan Mels <github@mels.email> * Ignore lastposition for isConnected check Signed-off-by: Arjan Mels <github@mels.email> * Updated to use ThingHandlerService Signed-off-by: Arjan Mels <github@mels.email> * Fixed various review findings Signed-off-by: Arjan Mels <github@mels.email> Co-authored-by: Arjan Mels <github@mels.email>
* Initial commit: template only Signed-off-by: Arjan Mels <github@mels.email> * Initial version Signed-off-by: Arjan Mels <github@mels.email> * Minor cleanup after rebase Signed-off-by: Arjan Mels <github@mels.email> * Corrected type "peugot" => "peugeot" Signed-off-by: Arjan Mels <github@mels.email> * Improved Exception messages Corrected URL Signed-off-by: Arjan Mels <github@mels.email> * Switched from vin to id Changed nextDelayedTime from ZonedDateTime to Duration Added vehcile etails and additional info retrieval Signed-off-by: Arjan Mels <github@mels.email> * Before rebase Signed-off-by: Arjan Mels <github@mels.email> * Various fixes Signed-off-by: Arjan Mels <github@mels.email> * Updated tests Signed-off-by: Arjan Mels <github@mels.email> * Changed double to BigDecimal to keep accuracy Added lastupdated channel Small corrections Signed-off-by: Arjan Mels <github@mels.email> * Updated to 3.1.0-SNAPSHOT Signed-off-by: Arjan Mels <github@mels.email> * Added README.md Signed-off-by: Arjan Mels <github@mels.email> * Changed channels to lowerCamelCase Signed-off-by: Arjan Mels <github@mels.email> * Minor corrections Signed-off-by: Arjan Mels <github@mels.email> * Corrected lastUpdated in thing-types.xml Signed-off-by: Arjan Mels <github@mels.email> * Fixed ToStringbuilder Signed-off-by: Arjan Mels <github@mels.email> * corrected capitalization in thing-types.xml and Constants Signed-off-by: Arjan Mels <github@mels.email> * Corrected URL for Citroen Signed-off-by: Arjan Mels <github@mels.email> * Added groupepsa binding to bom pom.xml Signed-off-by: Arjan Mels <github@mels.email> * Updated copyrights Signed-off-by: Arjan Mels <github@mels.email> * Fixed CheckStyle warnings Signed-off-by: Arjan Mels <github@mels.email> * Fixed check style notifications Signed-off-by: Arjan Mels <github@mels.email> * Updated readme Signed-off-by: Arjan Mels <github@mels.email> * Corrected capitalization of thing-types.xml Signed-off-by: Arjan Mels <github@mels.email> * Updated pom. xml to 3.3.0-SNAPSHOT Signed-off-by: Arjan Mels <github@mels.email> * Updated copyright messages Signed-off-by: Arjan Mels <github@mels.email> * Various minor cleanups Cleanup of the README.md Removed unnecessary license header form the feature.xml file Various null annotation corrections Further cleanup of thing-types.xml Cleanup of groupepsa.properties Signed-off-by: Arjan Mels <github@mels.email> * Logging updates Signed-off-by: Arjan Mels <github@mels.email> * Updated dependencies Added dependencies to NOTICE Signed-off-by: Arjan Mels <github@mels.email> * Ignore lastposition for isConnected check Signed-off-by: Arjan Mels <github@mels.email> * Updated to use ThingHandlerService Signed-off-by: Arjan Mels <github@mels.email> * Fixed various review findings Signed-off-by: Arjan Mels <github@mels.email> Co-authored-by: Arjan Mels <github@mels.email> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
This seems to have been forgotten as part of openhab#10332. Signed-off-by: Wouter Born <github@maindrain.net>
This seems to have been forgotten as part of openhab#10332. Signed-off-by: Wouter Born <github@maindrain.net>
This seems to have been forgotten as part of #10332. Signed-off-by: Wouter Born <github@maindrain.net>
This seems to have been forgotten as part of openhab#10332. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Ben Rosenblum <rosenblumb@gmail.com>
This seems to have been forgotten as part of openhab#10332. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
This seems to have been forgotten as part of openhab#10332. Signed-off-by: Wouter Born <github@maindrain.net>
* Initial commit: template only Signed-off-by: Arjan Mels <github@mels.email> * Initial version Signed-off-by: Arjan Mels <github@mels.email> * Minor cleanup after rebase Signed-off-by: Arjan Mels <github@mels.email> * Corrected type "peugot" => "peugeot" Signed-off-by: Arjan Mels <github@mels.email> * Improved Exception messages Corrected URL Signed-off-by: Arjan Mels <github@mels.email> * Switched from vin to id Changed nextDelayedTime from ZonedDateTime to Duration Added vehcile etails and additional info retrieval Signed-off-by: Arjan Mels <github@mels.email> * Before rebase Signed-off-by: Arjan Mels <github@mels.email> * Various fixes Signed-off-by: Arjan Mels <github@mels.email> * Updated tests Signed-off-by: Arjan Mels <github@mels.email> * Changed double to BigDecimal to keep accuracy Added lastupdated channel Small corrections Signed-off-by: Arjan Mels <github@mels.email> * Updated to 3.1.0-SNAPSHOT Signed-off-by: Arjan Mels <github@mels.email> * Added README.md Signed-off-by: Arjan Mels <github@mels.email> * Changed channels to lowerCamelCase Signed-off-by: Arjan Mels <github@mels.email> * Minor corrections Signed-off-by: Arjan Mels <github@mels.email> * Corrected lastUpdated in thing-types.xml Signed-off-by: Arjan Mels <github@mels.email> * Fixed ToStringbuilder Signed-off-by: Arjan Mels <github@mels.email> * corrected capitalization in thing-types.xml and Constants Signed-off-by: Arjan Mels <github@mels.email> * Corrected URL for Citroen Signed-off-by: Arjan Mels <github@mels.email> * Added groupepsa binding to bom pom.xml Signed-off-by: Arjan Mels <github@mels.email> * Updated copyrights Signed-off-by: Arjan Mels <github@mels.email> * Fixed CheckStyle warnings Signed-off-by: Arjan Mels <github@mels.email> * Fixed check style notifications Signed-off-by: Arjan Mels <github@mels.email> * Updated readme Signed-off-by: Arjan Mels <github@mels.email> * Corrected capitalization of thing-types.xml Signed-off-by: Arjan Mels <github@mels.email> * Updated pom. xml to 3.3.0-SNAPSHOT Signed-off-by: Arjan Mels <github@mels.email> * Updated copyright messages Signed-off-by: Arjan Mels <github@mels.email> * Various minor cleanups Cleanup of the README.md Removed unnecessary license header form the feature.xml file Various null annotation corrections Further cleanup of thing-types.xml Cleanup of groupepsa.properties Signed-off-by: Arjan Mels <github@mels.email> * Logging updates Signed-off-by: Arjan Mels <github@mels.email> * Updated dependencies Added dependencies to NOTICE Signed-off-by: Arjan Mels <github@mels.email> * Ignore lastposition for isConnected check Signed-off-by: Arjan Mels <github@mels.email> * Updated to use ThingHandlerService Signed-off-by: Arjan Mels <github@mels.email> * Fixed various review findings Signed-off-by: Arjan Mels <github@mels.email> Co-authored-by: Arjan Mels <github@mels.email>
This seems to have been forgotten as part of openhab#10332. Signed-off-by: Wouter Born <github@maindrain.net>
This seems to have been forgotten as part of openhab#10332. Signed-off-by: Wouter Born <github@maindrain.net>
This seems to have been forgotten as part of openhab#10332. Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
New Binding for Groupe PSA (Opel, Peugeot, Citroen, DS, Vauxhall) cars
Binding to retrieve information via the Groupe PSA Web API for cars.
A compiled version is available at: https://github.com/arjanmels/openhab2-addons/releases
Forum thread: https://community.openhab.org/t/new-binding-for-groupe-psa-peugeot-citroen-ds-opel-vauxhall-cars/110580/7
Testing by various forum members has taken place.