Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[somfytahoma] Improved handling of target temperature command #10336

Merged
merged 2 commits into from
Mar 21, 2021

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier lg.hc@free.fr

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from octa22 as a code owner March 15, 2021 11:39
@lolodomo
Copy link
Contributor Author

@octa22 ; please review, this is a fix for better handling of target temperature command. It now accepts a value with any temperature unit or a value without any unit.

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Copy link
Contributor

@octa22 octa22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo
Copy link
Contributor Author

@fwolter : please review

@fwolter fwolter merged commit 88022b1 into openhab:main Mar 21, 2021
@fwolter fwolter added this to the 3.1 milestone Mar 21, 2021
@lolodomo lolodomo deleted the somfytahoma_tempcmd branch March 21, 2021 13:27
@kaikreuzer kaikreuzer added the bug An unexpected problem or unintended behavior of an add-on label Apr 2, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…b#10336)

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants