Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve itest runbundles for Gson and Commons Lang upgrades and fix JsonParser deprecations #10345

Merged
merged 3 commits into from
Mar 18, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 17, 2021

Signed-off-by: Wouter Born <github@maindrain.net>
Copy link
Contributor

@marcelrv marcelrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for max & ntp bindings

@wborn wborn requested a review from tmrobert8 as a code owner March 17, 2021 11:11
@wborn wborn changed the title Resolve itest runbundles for Gson and Commons Lang upgrades Resolve itest runbundles for Gson and Commons Lang upgrades and fix JsonParser deprecations Mar 17, 2021
Copy link
Member

@pacive pacive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for SMHI binding

Signed-off-by: Wouter Born <github@maindrain.net>
Copy link
Contributor

@mhilbush mhilbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for squeezebox

@marcelrv
Copy link
Contributor

LGTM for max,miio,ntp & windcentrale bindings

@wborn wborn added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Mar 18, 2021
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn
Copy link
Member Author

wborn commented Mar 18, 2021

This will fix the build @openhab/add-ons-maintainers!

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit 580f293 into openhab:main Mar 18, 2021
@wborn wborn deleted the resolve-runbundles branch March 18, 2021 11:21
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/missing-requirement-osgi-wiring-package-com-google-gson-internal/119338/2

@wborn wborn added this to the 3.1 milestone Mar 21, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…sonParser deprecations (openhab#10345)

* Resolve itest runbundles for Gson and Commons Lang upgrades
* Fix JsonParser deprecations too
* Fix feature verification

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
…sonParser deprecations (openhab#10345)

* Resolve itest runbundles for Gson and Commons Lang upgrades
* Fix JsonParser deprecations too
* Fix feature verification

Signed-off-by: Wouter Born <github@maindrain.net>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
…sonParser deprecations (openhab#10345)

* Resolve itest runbundles for Gson and Commons Lang upgrades
* Fix JsonParser deprecations too
* Fix feature verification

Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…sonParser deprecations (openhab#10345)

* Resolve itest runbundles for Gson and Commons Lang upgrades
* Fix JsonParser deprecations too
* Fix feature verification

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants