[somfytahoma] New method to send a command to several devices in the same place #10347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…same place Also include the place into the inbox label (discovery) Signed-off-by: Laurent Garnier <lg.hc@free.fr>
wborn
added
rebuild
octa22
reviewed
Mar 20, 2021
...java/org/openhab/binding/somfytahoma/internal/discovery/SomfyTahomaItemDiscoveryService.java
Outdated
Show resolved
Hide resolved
octa22
reviewed
Mar 20, 2021
There was a problem hiding this comment.
Generally I am asking myself why we should have this code increment, if it does not bring any new channel, so there is no added value of this code for users. Sorry if I am missing something, but I would at lease expect a way how to invoke this method sendCommandToSameDevicesInPlace
|
I try to provide small PR to move to my final PR for Cozytouch integration. |
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
|
Note that you will be able later to enable the "room" feature for certain Tahoma devices the same way I do it for Cozytouch radiators. But it has to be thought (by you) on what devices it makes really sense. |
|
OK, I understand |
|
@fwolter : please review |
|
@openhab/add-ons-maintainers : please review & merge. |
kaikreuzer
added
the
enhancement
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…same place (openhab#10347) * [somfytahoma] New method to send a command to several devices in the same place Also include the place into the inbox label (discovery) Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: remove unnecessary method Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…same place (openhab#10347) * [somfytahoma] New method to send a command to several devices in the same place Also include the place into the inbox label (discovery) Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: remove unnecessary method Signed-off-by: Laurent Garnier <lg.hc@free.fr>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…same place (openhab#10347) * [somfytahoma] New method to send a command to several devices in the same place Also include the place into the inbox label (discovery) Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: remove unnecessary method Signed-off-by: Laurent Garnier <lg.hc@free.fr>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…same place (openhab#10347) * [somfytahoma] New method to send a command to several devices in the same place Also include the place into the inbox label (discovery) Signed-off-by: Laurent Garnier <lg.hc@free.fr> * Review comment: remove unnecessary method Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also include the place into the inbox label (discovery)
Signed-off-by: Laurent Garnier lg.hc@free.fr