Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enocean] Do not set attr "required" for the param "senderIdOffset" #10370

Merged
merged 1 commit into from
Mar 21, 2021

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier lg.hc@free.fr

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from fruggy83 as a code owner March 21, 2021 13:38
@lolodomo
Copy link
Contributor Author

To be coherent with the philosophy of this binding which is to set the param attr "required" only when its value is "true".

@wborn wborn merged commit 65b7467 into openhab:main Mar 21, 2021
@lolodomo lolodomo deleted the enocean_requiredfalse branch March 21, 2021 18:18
@wborn wborn added this to the 3.1 milestone Mar 21, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…penhab#10370)

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants