Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken configfile GAV with karaf:kar #10391

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

wborn
Copy link
Member

@wborn wborn commented Mar 25, 2021

The groupId variable results in the wrong configfile GAV when building a single KAR with karaf:kar for an add-on.

The groupId variable results in the wrong configfile GAV when building a single KAR with karaf:kar for an add-on.

Signed-off-by: Wouter Born <github@maindrain.net>
Copy link
Member

@martinvw martinvw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kaikreuzer kaikreuzer merged commit 6e1119a into openhab:main Mar 26, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Mar 26, 2021
@wborn wborn deleted the karaf-kar-configfile branch March 26, 2021 07:54
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
The groupId variable results in the wrong configfile GAV when building a single KAR with karaf:kar for an add-on.

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
The groupId variable results in the wrong configfile GAV when building a single KAR with karaf:kar for an add-on.

Signed-off-by: Wouter Born <github@maindrain.net>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
The groupId variable results in the wrong configfile GAV when building a single KAR with karaf:kar for an add-on.

Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
The groupId variable results in the wrong configfile GAV when building a single KAR with karaf:kar for an add-on.

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants