Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] add support Mi Smart LED Bulb Essential (yeelink.light.color5) #10531

Merged
merged 4 commits into from
Apr 27, 2021

Conversation

marcelrv
Copy link
Contributor

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added the enhancement An enhancement or new feature for an existing add-on label Apr 15, 2021
@marcelrv marcelrv requested a review from cpmeister April 15, 2021 21:37
@marcelrv marcelrv linked an issue Apr 16, 2021 that may be closed by this pull request
Comment on lines 3276 to 3277
| colorTemperature | Number | Color Temperature | |
| colorMode | Number | Color Mode | |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give a short description how this can be used. E.g. the value range.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the requestor @migue74 can test and confirm. I don't own such light.
My understanding is that this is for selecting RGB, white or other modes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised the options were already in the file... just not highlighted in the readme.

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv requested a review from fwolter April 27, 2021 18:29
@fwolter fwolter merged commit 84bd5ad into openhab:main Apr 27, 2021
@fwolter fwolter added this to the 3.1 milestone Apr 27, 2021
@marcelrv marcelrv deleted the miio-ylcolor5 branch April 28, 2021 07:22
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
…openhab#10531)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[miio] Support yeelink.light.color5
2 participants