Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1 #10534

Merged
merged 4 commits into from
Apr 27, 2021
Merged

[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1 #10534

merged 4 commits into from
Apr 27, 2021

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Apr 16, 2021 •
edited by wborn
Loading

Closes #10526

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

@marcelrv
[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1
6cb0cc7 
closing openhab#10526


Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@cweitkamp cweitkamp added rebuild Triggers Jenkins PR build enhancement An enhancement or new feature for an existing add-on and removed rebuild Triggers Jenkins PR build labels Apr 22, 2021
@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Apr 24, 2021
@marcelrv marcelrv added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Apr 25, 2021
@wborn
Copy link
Member

wborn commented Apr 26, 2021 •
edited
Loading

According to Jenkins SAT found this error:

[ERROR] Code Analysis Tool has found: 
 1 error(s)! 
 0 warning(s) 
 12 info(s)
[ERROR] .binding.miio/README.md:[1]
File does not end with a newline.

@marcelrv
[miio] add LF
3500f5a 
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv
Copy link
Contributor Author

@wborn this should be fixed now... jenkins is still stuck somewhere, but I think it is unrelated to the PR

@wborn wborn added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Apr 27, 2021
wborn
wborn approved these changes Apr 27, 2021
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the support!

@wborn wborn merged commit 61a3705 into openhab:main Apr 27, 2021
@wborn wborn added this to the 3.1 milestone Apr 27, 2021
@marcelrv marcelrv deleted the miio-airpuri-za1 branch April 28, 2021 07:22
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@marcelrv @themillhousegroup
[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1 (openhab…
fa94dec 
…#10534)

Closes openhab#10526

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@marcelrv @computergeek1507
[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1 (openhab…
455c0fd 
…#10534)

Closes openhab#10526

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@marcelrv @frederictobiasc
[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1 (openhab…
7a030a6 
…#10534)

Closes openhab#10526

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@marcelrv @thinkingstone
[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1 (openhab…
3cfbc25 
…#10534)

Closes openhab#10526

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@marcelrv
[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1 (openhab…
d73f919 
…#10534)

Closes openhab#10526

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[miio] Support of Smartmi Air Purifier zhimi.airpurifier.za1
3 participants
@marcelrv @wborn @cweitkamp