[Jinja] Update JinJava version and embed dependencies #10496 #10578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 25, 2021 13:48
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
wborn
added
rebuild
kaikreuzer
approved these changes
Apr 25, 2021
kaikreuzer
added a commit
to openhab/openhab-osgiify
that referenced
this pull request
Apr 26, 2021
Related to openhab/openhab-addons#10578 Signed-off-by: Kai Kreuzer <kai@openhab.org>
wborn
pushed a commit
to openhab/openhab-osgiify
that referenced
this pull request
Apr 26, 2021
Related to openhab/openhab-addons#10578 Signed-off-by: Kai Kreuzer <kai@openhab.org>
themillhousegroup
pushed a commit
to themillhousegroup/openhab2-addons
that referenced
this pull request
May 10, 2021
…penhab#10578) Signed-off-by: Anton Kharuzhy <antroids@gmail.com> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
…penhab#10578) Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…penhab#10578) Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…penhab#10578) Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…penhab#10578) Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #10496 openhab/openhab-osgiify#17 openhab/openhab-osgiify#18
All dependencies for JinJava 2.5.0 were resolved by OSGIified versions declared in feature.xml for some reason. This way requires PRs to openhab-osgiify repository on each dependency update and this is very inconvenient.
By this PR, dependencies used by Jinja Transformation are moved back to pom.xml. I left Jackson, Jsoup, commons-net and commons-lang3 in feature.xml, because they are used by other bundles and they have actual bundles in Maven repository.
Code review is required, because I have no experience in OSGi.