Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jinja] Empty string result when binding is missing #10581

Merged
merged 1 commit into from
Apr 27, 2021

Conversation

antroids
Copy link
Contributor

Signed-off-by: Anton Kharuzhy antroids@gmail.com

The new JinJava 2.5.7 allows to handle missing map keys.
This PR enables validation and wraps FatalTemplateErrorsException into TransformationException, according to TransformationService contract.

Linked issue: #10496

Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
@antroids antroids requested a review from jochen314 as a code owner April 25, 2021 21:25
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@wborn wborn linked an issue Apr 26, 2021 that may be closed by this pull request
@wborn wborn changed the title [jinja] Empty string result when binding is missing, fixes #10496 [jinja] Empty string result when binding is missing Apr 26, 2021
@wborn wborn added the bug An unexpected problem or unintended behavior of an add-on label Apr 26, 2021
@martinvw martinvw merged commit 2110e13 into openhab:main Apr 27, 2021
@martinvw
Copy link
Member

Sorry :-) We might have been waiting on @jochen314 here, let me know if there is something which needs to be done / reverted.

@wborn wborn added this to the 3.1 milestone Apr 28, 2021
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Anton Kharuzhy <antroids@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[jinja] Empty string result when binding is missing
4 participants