Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sonos] Play notification while playing virtual line-in #10599

Merged
merged 4 commits into from
May 5, 2021
Merged

[sonos] Play notification while playing virtual line-in #10599

merged 4 commits into from
May 5, 2021

Conversation

lolodomo
Copy link
Contributor

Fix #10569

Signed-off-by: Laurent Garnier lg.hc@free.fr

@lolodomo
[sonos] Play notification while playing virtual line-in
3f1e971 
Fix openhab#10569

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo requested a review from kgoderis as a code owner April 27, 2021 17:06
@lolodomo
Add a log in case the notification feature is not yet implemented
16f0b3f 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@wborn wborn added the bug An unexpected problem or unintended behavior of an add-on label Apr 28, 2021
@lolodomo
Rename few methods for better meaning
34b8ed2 
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
@lolodomo lolodomo added rebuild Triggers Jenkins PR build bug An unexpected problem or unintended behavior of an add-on and removed bug An unexpected problem or unintended behavior of an add-on rebuild Triggers Jenkins PR build labels Apr 29, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-sonos-audio-sink-not-working/121734/12

@lolodomo
Copy link
Contributor Author

lolodomo commented May 3, 2021

Here is a new jar for testing, compatible with 3.1 M4:
sonos.zip

@lolodomo
Copy link
Contributor Author

lolodomo commented May 4, 2021

@cweitkamp @wborn : That's strange, when I look at the build console output, the build succeeded but the last line os "Finished: UNSTABLE". Is it the reason why the build is finially mentioned as KO in the PR and what is generating this "UNSTABLE" ?

@wborn
Copy link
Member

wborn commented May 4, 2021 •
edited
Loading

All add-on builds currently suffer from this. I already tried restarting Jenkins but it is very stubborn about this false positive. 🙁

@kaikreuzer
Copy link
Member

The main build is unstable because of a failing test: https://ci.openhab.org/job/openHAB-Addons/lastCompletedBuild/org.openhab.addons.bundles$org.openhab.io.hueemulation/testReport/org.openhab.io.hueemulation.internal.upnp/UpnpTests/descriptionWithAddress/

Not sure if this could be in any way related?

cweitkamp
cweitkamp approved these changes May 5, 2021
View reviewed changes
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@cweitkamp cweitkamp merged commit 4efccac into openhab:main May 5, 2021
@cweitkamp cweitkamp added this to the 3.1 milestone May 5, 2021
@lolodomo lolodomo deleted the sonos_vli branch May 5, 2021 20:41
themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
@lolodomo @themillhousegroup
[sonos] Play notification while playing virtual line-in (openhab#10599)
734512b 
* Play notification while playing virtual line-in

Fix openhab#10569

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@lolodomo @computergeek1507
[sonos] Play notification while playing virtual line-in (openhab#10599)
5ad6cde 
* Play notification while playing virtual line-in

Fix openhab#10569

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@lolodomo @frederictobiasc
[sonos] Play notification while playing virtual line-in (openhab#10599)
1839212 
* Play notification while playing virtual line-in

Fix openhab#10569

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@lolodomo @thinkingstone
[sonos] Play notification while playing virtual line-in (openhab#10599)
0115e64 
* Play notification while playing virtual line-in

Fix openhab#10569

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@lolodomo
[sonos] Play notification while playing virtual line-in (openhab#10599)
d7db2fb 
* Play notification while playing virtual line-in

Fix openhab#10569

Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cweitkamp cweitkamp cweitkamp approved these changes

@kgoderis kgoderis Awaiting requested review from kgoderis kgoderis is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on community approved
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

[sonos] notification sound not played (anymore) when spotify playlist is running on sonos box
5 participants
@lolodomo @openhab-bot @wborn @kaikreuzer @cweitkamp