Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use activation-api 1.2.1_3 #10646

Merged
merged 1 commit into from
May 5, 2021
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented May 4, 2021

Fixes openhab#10642

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn requested review from syphr42 and a team as code owners May 4, 2021 07:37
@cweitkamp
Copy link
Contributor

cweitkamp commented May 4, 2021

Maybe I am dumbfounded again - but I don't understand why it does work for mail and pushbullet but not for tellstick? Don't we have to change these feature files too?

<bundle dependency="true">mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.activation-api-1.1/2.9.0</bundle>

<bundle dependency="true">mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.activation-api-1.1/2.9.0</bundle>

@wborn
Copy link
Member Author

wborn commented May 4, 2021

@kaikreuzer
Copy link
Member

So @kaikreuzer can also fix this for the M4 by uploading the old dependency. 🙂

Sorry, what is currently broken and what old dependencies are exactly required...?

@wborn
Copy link
Member Author

wborn commented May 4, 2021

The Tellstick Binding does not work in 3.1.0.M4 as described in the linked issue (#10642) because the online repo does not have 1.2.1_2. So this PR fixes it by using 1.2.1_3 instead of 1.2.1_2. But you could also fix it for 3.1.0.M4 by adding 1.2.1_2 to the online repo.

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of an add-on label May 5, 2021
@cweitkamp cweitkamp added this to the 3.1 milestone May 5, 2021
@cweitkamp cweitkamp merged commit 940e1e5 into openhab:main May 5, 2021
@wborn wborn deleted the use-activation-api-1.2.1_3 branch May 5, 2021 19:08
@jorkki22
Copy link

jorkki22 commented May 7, 2021

The Tellstick Binding does not work in 3.1.0.M4 as described in the linked issue (#10642) because the online repo does not have 1.2.1_2. So this PR fixes it by using 1.2.1_3 instead of 1.2.1_2. But you could also fix it for 3.1.0.M4 by adding 1.2.1_2 to the online repo.

Sorry, not so familiar with github. The ticket is now closed, does this mean this will be fixed later possibly in M5, but not in M4? If so is there any workaround for making tellstick binding work before that?

@wborn
Copy link
Member Author

wborn commented May 7, 2021

does this mean this will be fixed later possibly in M5, but not in M4

Yes, unless 1.2.1_2 is uploaded to the online repo.

If so is there any workaround for making tellstick binding work before that?

The missing dependency is part of the offline addons KAR file. I.e. you can use that by downloading openhab-addons-3.1.0.M4.kar to your /addons dir. If you use an APT based deployment you can also install it with: sudo apt-get install openhab-addons

The online installation should also work again if you switch to the 3.1.0 snapshots.

@kaikreuzer
Copy link
Member

Yes, unless 1.2.1_2 is uploaded to the online repo.

I just uploaded it, so everything should be fine now for M4 as well!

@jorkki22
Copy link

jorkki22 commented May 8, 2021

Confirmed, working again. Thanks everybody.

themillhousegroup pushed a commit to themillhousegroup/openhab2-addons that referenced this pull request May 10, 2021
Fixes openhab#10642

Signed-off-by: Wouter Born <github@maindrain.net>
Signed-off-by: John Marshall <john.marshall.au@gmail.com>
@wborn wborn removed the bug An unexpected problem or unintended behavior of an add-on label Jun 22, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
Fixes openhab#10642

Signed-off-by: Wouter Born <github@maindrain.net>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
Fixes openhab#10642

Signed-off-by: Wouter Born <github@maindrain.net>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Fixes openhab#10642

Signed-off-by: Wouter Born <github@maindrain.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Fixes openhab#10642

Signed-off-by: Wouter Born <github@maindrain.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tellstick] binding fails to start after upgrade to OH3.1.0 M4
4 participants