-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use activation-api 1.2.1_3 #10646
Use activation-api 1.2.1_3 #10646
Conversation
Fixes openhab#10642 Signed-off-by: Wouter Born <github@maindrain.net>
Maybe I am dumbfounded again - but I don't understand why it does work for mail and pushbullet but not for tellstick? Don't we have to change these feature files too?
openhab-addons/bundles/org.openhab.binding.pushbullet/src/main/feature/feature.xml Line 7 in e24d43a
|
Yes I can explain this. It seems like @kaikreuzer only uploaded 1.2.1_3 to the online repo, see: So @kaikreuzer can also fix this for the M4 by uploading the old dependency. 🙂 |
Sorry, what is currently broken and what old dependencies are exactly required...? |
The Tellstick Binding does not work in 3.1.0.M4 as described in the linked issue (#10642) because the online repo does not have 1.2.1_2. So this PR fixes it by using 1.2.1_3 instead of 1.2.1_2. But you could also fix it for 3.1.0.M4 by adding 1.2.1_2 to the online repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Sorry, not so familiar with github. The ticket is now closed, does this mean this will be fixed later possibly in M5, but not in M4? If so is there any workaround for making tellstick binding work before that? |
Yes, unless 1.2.1_2 is uploaded to the online repo.
The missing dependency is part of the offline addons KAR file. I.e. you can use that by downloading openhab-addons-3.1.0.M4.kar to your The online installation should also work again if you switch to the 3.1.0 snapshots. |
I just uploaded it, so everything should be fine now for M4 as well! |
Confirmed, working again. Thanks everybody. |
Fixes openhab#10642 Signed-off-by: Wouter Born <github@maindrain.net> Signed-off-by: John Marshall <john.marshall.au@gmail.com>
Fixes openhab#10642 Signed-off-by: Wouter Born <github@maindrain.net>
Fixes openhab#10642 Signed-off-by: Wouter Born <github@maindrain.net>
Fixes openhab#10642 Signed-off-by: Wouter Born <github@maindrain.net>
Fixes openhab#10642 Signed-off-by: Wouter Born <github@maindrain.net>
Fixes #10642
Related to openhab/openhab-core#2292, openhab/openhab-distro#1256