Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[influxdb] Fix issue #10464 Problem querying old historical data #10680

Merged
merged 1 commit into from
May 14, 2021
Merged

[influxdb] Fix issue #10464 Problem querying old historical data #10680

merged 1 commit into from
May 14, 2021

Conversation

lujop
Copy link
Contributor

@lujop lujop commented May 12, 2021

Fixes issue #10464

Problem was introduced in #9943 and it's reproducible with historical Influx1 data that was generated with addon version <3.0.0 that didn't store item tag in points.

Generated binary to test:

org.openhab.persistence.influxdb-3.1.0-SNAPSHOT.zip

@lujop
Fix openhab#10464
b75275d 
Fix problem with historical  Influx1 data that was generated with addon version <3.0.0 that didn't write generate item tag
Signed-off-by: Joan Pujol <joanpujol@gmail.com>
@lujop lujop mentioned this pull request May 12, 2021
Closed
@cweitkamp cweitkamp linked an issue May 13, 2021 that may be closed by this pull request
InfluxDB Persistence not working anymore in 3.1.0-M3 build #10464
Closed
@cweitkamp cweitkamp added the bug An unexpected problem or unintended behavior of an add-on label May 13, 2021
wborn
wborn approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @lujop!

@wborn wborn merged commit 801100c into openhab:main May 14, 2021
@wborn wborn added this to the 3.1 milestone May 14, 2021
@DerOetzi
Copy link
Contributor

Sorry wasn't online for a while. Thanks @luljop for fixing!

@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/influx-db2-openhab-3-1m5-deltasince-start-of-day-not-working-when-lines-without-item-name-in-database-from-openhab-2-5/123546/8

@t2000 t2000 mentioned this pull request Jun 20, 2021
Closed
t2000 added a commit to t2000/openhab2-addons that referenced this pull request Jun 20, 2021
@t2000
[influxdb] v2: Fix history queries if items are not tagged
46ed344 
Was missing in openhab#10680

Fixes openhab#10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
@t2000 t2000 mentioned this pull request Jun 20, 2021
Merged
kaikreuzer pushed a commit that referenced this pull request Jun 21, 2021
@t2000
[influxdb] v2: Fix history queries if items are not tagged (#10888)
7c221d0 
Was missing in #10680

Fixes #10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@lujop @computergeek1507
[influxdb] Fix problems when querying old historical data (openhab#10680
586f006 
)

Fix problem with historical  Influx1 data that was generated with addon version <3.0.0 that didn't write generate item tag

Signed-off-by: Joan Pujol <joanpujol@gmail.com>
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@t2000 @computergeek1507
[influxdb] v2: Fix history queries if items are not tagged (openhab#1…
1c2e730 
…0888)

Was missing in openhab#10680

Fixes openhab#10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@t2000 @lucacalcaterra
[influxdb] v2: Fix history queries if items are not tagged (openhab#1…
16269b4 
…0888)

Was missing in openhab#10680

Fixes openhab#10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@t2000 @lucacalcaterra
[influxdb] v2: Fix history queries if items are not tagged (openhab#1…
4d8ce32 
…0888)

Was missing in openhab#10680

Fixes openhab#10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
@t2000 @lucacalcaterra
[influxdb] v2: Fix history queries if items are not tagged (openhab#1…
5806985 
…0888)

Was missing in openhab#10680

Fixes openhab#10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@lujop @frederictobiasc
[influxdb] Fix problems when querying old historical data (openhab#10680
18ad9d9 
)

Fix problem with historical  Influx1 data that was generated with addon version <3.0.0 that didn't write generate item tag

Signed-off-by: Joan Pujol <joanpujol@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@t2000 @frederictobiasc
[influxdb] v2: Fix history queries if items are not tagged (openhab#1…
8c9a348 
…0888)

Was missing in openhab#10680

Fixes openhab#10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@lujop @thinkingstone
[influxdb] Fix problems when querying old historical data (openhab#10680
6881e97 
)

Fix problem with historical  Influx1 data that was generated with addon version <3.0.0 that didn't write generate item tag

Signed-off-by: Joan Pujol <joanpujol@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@t2000 @thinkingstone
[influxdb] v2: Fix history queries if items are not tagged (openhab#1…
9c08540 
…0888)

Was missing in openhab#10680

Fixes openhab#10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
marcfischerboschio pushed a commit to marcfischerboschio/openHABaddon that referenced this pull request Apr 20, 2022
@t2000
[influxdb] v2: Fix history queries if items are not tagged (#10888)
03f931e 
Was missing in openhab/openhab-addons#10680

Fixes #10887

Signed-off-by: Stefan Triller <github@stefantriller.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@lujop
[influxdb] Fix problems when querying old historical data (openhab#10680
611317c 
)

Fix problem with historical  Influx1 data that was generated with addon version <3.0.0 that didn't write generate item tag

Signed-off-by: Joan Pujol <joanpujol@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.

InfluxDB Persistence not working anymore in 3.1.0-M3 build
5 participants
@lujop @DerOetzi @openhab-bot @wborn @cweitkamp