Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kodi] Added support for publishing ChannelDescriptionChangedEvents #10717

Merged
merged 1 commit into from
Jun 21, 2021
Merged

[kodi] Added support for publishing ChannelDescriptionChangedEvents #10717

merged 1 commit into from
Jun 21, 2021

Conversation

cweitkamp
Copy link
Contributor

  • Added service references to DynamicCommandDescriptionProvider and DynamicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvents

Depends on openhab/openhab-core#1505

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

@cweitkamp
Added service references to DynamicCommandDescriptionProvider and Dyn…
c1ae261 
…amicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@cweitkamp cweitkamp added enhancement An enhancement or new feature for an existing add-on awaiting other PR Depends on another PR labels May 18, 2021
@cweitkamp cweitkamp requested a review from pail23 as a code owner May 18, 2021 15:48
@lolodomo
Copy link
Contributor

one question for you @cweitkamp : when tagging "Activate" on the constructor, are we sure that the activate method of the parent class will be called ? This method is initializing the field bundleContext.

@cweitkamp
Copy link
Contributor Author

Yes, if the activate method is annotated by @Activate too. OSGi framework calls every method after the bundle has been marked as being ready.

@lolodomo
Copy link
Contributor

Thank you for the explanation.

@lolodomo
Copy link
Contributor

lolodomo commented Jun 21, 2021 •
edited
Loading

Depending PR in core repo is now merged. So we are ready to merge this one.

@lolodomo lolodomo removed the awaiting other PR Depends on another PR label Jun 21, 2021
@cweitkamp cweitkamp added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jun 21, 2021
@kaikreuzer kaikreuzer merged commit 48f4fd7 into openhab:main Jun 21, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone Jun 21, 2021
@cweitkamp cweitkamp deleted the feature-kodi-command-description-changed-events branch June 21, 2021 21:20
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
@cweitkamp @computergeek1507
Added service references to DynamicCommandDescriptionProvider and Dyn…
f581c67 
…amicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent (openhab#10717)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@cweitkamp @lucacalcaterra
Added service references to DynamicCommandDescriptionProvider and Dyn…
a20093d 
…amicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent (openhab#10717)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Jul 26, 2021
@cweitkamp @lucacalcaterra
Added service references to DynamicCommandDescriptionProvider and Dyn…
f1866fd 
…amicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent (openhab#10717)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra pushed a commit to lucacalcaterra/openhab-addons that referenced this pull request Aug 3, 2021
@cweitkamp @lucacalcaterra
Added service references to DynamicCommandDescriptionProvider and Dyn…
8318687 
…amicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent (openhab#10717)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@cweitkamp @frederictobiasc
Added service references to DynamicCommandDescriptionProvider and Dyn…
c30a977 
…amicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent (openhab#10717)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@cweitkamp @thinkingstone
Added service references to DynamicCommandDescriptionProvider and Dyn…
0596d6c 
…amicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent (openhab#10717)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@cweitkamp
Added service references to DynamicCommandDescriptionProvider and Dyn…
6861aaf 
…amicStateDescriptionProvider to support publishing ChannelDescriptionChangedEvent (openhab#10717)

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@pail23 pail23 Awaiting requested review from pail23 pail23 is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@cweitkamp @lolodomo @kaikreuzer