Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmiweather] Fixed to work with new API #10765

Merged
merged 2 commits into from
May 29, 2021

Conversation

ssalonen
Copy link
Contributor

@ssalonen ssalonen commented May 27, 2021

Updated code to work with FMI Weather API changes

XML namespace target namespace changed from

http://xml.fmi.fi/namespace/om/atmosphericfeatures/1.0 to http://xml.fmi.fi/namespace/om/atmosphericfeatures/1.1

ssalonen added 2 commits May 27, 2021 21:27
Tests updated as well

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Signed-off-by: Sami Salonen <ssalonen@gmail.com>
@ssalonen ssalonen changed the title [fmiweather] Fmiweather api update [fmiweather] Fixed to work with new API May 27, 2021
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer merged commit 572fd3d into openhab:main May 29, 2021
@kaikreuzer kaikreuzer added this to the 3.1 milestone May 29, 2021
@kaikreuzer kaikreuzer added the enhancement An enhancement or new feature for an existing add-on label May 29, 2021
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/fmiweather-binding-unexpected-api-response/122546/6

computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
Tests updated as well

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
Tests updated as well

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
Tests updated as well

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Tests updated as well

Signed-off-by: Sami Salonen <ssalonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants