[rfxcom] Add support for receiving RAW messages #10833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a new feature in the Pro firmwares that provides the real raw RF pulse lengths as shorts. Good for being able to parrot switches that aren't otherwise supported, once we add the tx support as well. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
martinvw
reviewed
Jun 9, 2021
| switch (channelId) { | ||
| case CHANNEL_RAW_MESSAGE: | ||
| if (type instanceof StringType) { | ||
| // TODO: Check the raw message for validity (length, no more than 124 shorts, multiple of 4 bytes in |
There was a problem hiding this comment.
There is a TODO, what should be done and can it be completed before merging the PR?
There was a problem hiding this comment.
This is really a TODO for when I implement tx, which is next. There is value in merging rx.
|
|
||
| case CHANNEL_RAW_PAYLOAD: | ||
| if (type instanceof StringType) { | ||
| // TODO: Check the payload for validity (no more than 124 shorts, multiple of 4 bytes |
There was a problem hiding this comment.
There is a TODO, what should be done and can it be completed before merging the PR?
There was a problem hiding this comment.
This is really a TODO for when I implement tx, which is next. There is value in merging rx.
| @@ -145,6 +145,7 @@ | |||
| private static final ThingTypeUID THING_TYPE_POWER = new ThingTypeUID(BINDING_ID, "power"); | |||
| private static final ThingTypeUID THING_TYPE_RADIATOR1 = new ThingTypeUID(BINDING_ID, "radiator1"); | |||
| private static final ThingTypeUID THING_TYPE_RAIN = new ThingTypeUID(BINDING_ID, "rain"); | |||
| private static final ThingTypeUID THING_TYPE_RAW = new ThingTypeUID(BINDING_ID, "raw"); | |||
There was a problem hiding this comment.
Just out of curiosity what is the difference with undecoded
There was a problem hiding this comment.
UNDECODED is where the RFXCOM understands the type, but just hasn't broken it down into values. RAW is where the RFXCOM has received an RF message and hasn't tried to do anything to it at all, so the values are the ms pulse timings that would need to be processed into stable bytes before they could even be decoded.
|
Does it make to wait with merging until the tx support is added? |
|
I would merge it, it adds value as is. Not sure when exactly I'll find time to do the tx side. |
martinvw
approved these changes
Jun 14, 2021
martinvw
added
the
enhancement
computergeek1507
pushed a commit
to computergeek1507/openhab-addons
that referenced
this pull request
Jul 13, 2021
This is a new feature in the Pro firmwares that provides the real raw RF pulse lengths as shorts. Good for being able to parrot switches that aren't otherwise supported, once we add the tx support as well. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
This is a new feature in the Pro firmwares that provides the real raw RF pulse lengths as shorts. Good for being able to parrot switches that aren't otherwise supported, once we add the tx support as well. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Jul 26, 2021
This is a new feature in the Pro firmwares that provides the real raw RF pulse lengths as shorts. Good for being able to parrot switches that aren't otherwise supported, once we add the tx support as well. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
lucacalcaterra
pushed a commit
to lucacalcaterra/openhab-addons
that referenced
this pull request
Aug 3, 2021
This is a new feature in the Pro firmwares that provides the real raw RF pulse lengths as shorts. Good for being able to parrot switches that aren't otherwise supported, once we add the tx support as well. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com> Signed-off-by: Luca Calcaterra <calcaterra.luca@gmail.com>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
This is a new feature in the Pro firmwares that provides the real raw RF pulse lengths as shorts. Good for being able to parrot switches that aren't otherwise supported, once we add the tx support as well. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
This is a new feature in the Pro firmwares that provides the real raw RF pulse lengths as shorts. Good for being able to parrot switches that aren't otherwise supported, once we add the tx support as well. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
This is a new feature in the Pro firmwares that provides the real raw RF pulse lengths as shorts. Good for being able to parrot switches that aren't otherwise supported, once we add the tx support as well. Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new feature in the Pro firmwares that provides the real raw RF
pulse lengths as shorts. Good for being able to parrot switches that aren't
otherwise supported, once we add the tx support as well.
Signed-off-by: James Hewitt james.hewitt@uk.ibm.com