[ihc] Improve command handling when controller is not ready #10895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When connection from binding to IHC controller is open, but controller is in programming state, things state is offline with special status to indicate that binding can't send or receive any resource updates at the moment. Things status check during command sending will prevent unnecessary resource updates which will eventually fail and binding then tries to restart the connection. Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
kaikreuzer
requested changes
Jun 22, 2021
| @@ -212,6 +212,11 @@ public void handleCommand(ChannelUID channelUID, Command command) { | |||
| return; | |||
| } | |||
|
|
|||
| if (thing.getStatus() != ThingStatus.ONLINE) { | |||
| logger.warn("Controller is not ONLINE state, abort resource value update for channel '{}'!", channelUID); | |||
There was a problem hiding this comment.
Suggested change
| logger.warn("Controller is not ONLINE state, abort resource value update for channel '{}'!", channelUID); | |
| logger.debug("Controller is not ONLINE, aborting resource value update for channel '{}'!", channelUID); |
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Skinah
added
enhancement
Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
martinvw
added
rebuild
kaikreuzer
changed the title
dw-8
pushed a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
…#10895) * [ihc] Improved command handling when controller is not ready When connection from binding to IHC controller is open, but controller is in programming state, things state is offline with special status to indicate that binding can't send or receive any resource updates at the moment. Things status check during command sending will prevent unnecessary resource updates which will eventually fail and binding then tries to restart the connection. Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8
added a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
…penhab#10895)" This reverts commit 2a683ed.
dw-8
pushed a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
…#10895) * [ihc] Improved command handling when controller is not ready When connection from binding to IHC controller is open, but controller is in programming state, things state is offline with special status to indicate that binding can't send or receive any resource updates at the moment. Things status check during command sending will prevent unnecessary resource updates which will eventually fail and binding then tries to restart the connection. Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8
added a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
…penhab#10895)" This reverts commit 2a683ed. Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…#10895) * [ihc] Improved command handling when controller is not ready When connection from binding to IHC controller is open, but controller is in programming state, things state is offline with special status to indicate that binding can't send or receive any resource updates at the moment. Things status check during command sending will prevent unnecessary resource updates which will eventually fail and binding then tries to restart the connection. Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
…#10895) * [ihc] Improved command handling when controller is not ready When connection from binding to IHC controller is open, but controller is in programming state, things state is offline with special status to indicate that binding can't send or receive any resource updates at the moment. Things status check during command sending will prevent unnecessary resource updates which will eventually fail and binding then tries to restart the connection. Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…#10895) * [ihc] Improved command handling when controller is not ready When connection from binding to IHC controller is open, but controller is in programming state, things state is offline with special status to indicate that binding can't send or receive any resource updates at the moment. Things status check during command sending will prevent unnecessary resource updates which will eventually fail and binding then tries to restart the connection. Signed-off-by: Pauli Anttila <pauli.anttila@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connection from binding to IHC controller is open, but controller
is in programming state, things state is offline with special status to
indicate that binding can't send or receive any resource updates at the
moment. Things status check during command sending will prevent
unnecessary resource updates which will eventually fail and binding then
tries to restart the connection.
Signed-off-by: Pauli Anttila pauli.anttila@gmail.com