-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hydrawise] Migrate to new GraphQL based API #10947
Conversation
Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is one checkstyle warning left, which can be easily fixed.
....hydrawise/src/main/java/org/openhab/binding/hydrawise/internal/HydrawiseHandlerFactory.java
Outdated
Show resolved
Hide resolved
....hydrawise/src/main/java/org/openhab/binding/hydrawise/internal/HydrawiseHandlerFactory.java
Outdated
Show resolved
Hide resolved
....hydrawise/src/main/java/org/openhab/binding/hydrawise/internal/HydrawiseHandlerFactory.java
Outdated
Show resolved
Hide resolved
...g/openhab/binding/hydrawise/internal/discovery/HydrawiseCloudControllerDiscoveryService.java
Outdated
Show resolved
Hide resolved
...se/src/main/java/org/openhab/binding/hydrawise/internal/handler/HydrawiseAccountHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/things.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/things.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Thanks @fwolter as always for taking the time to review this PR! I have addressed all your comments. |
...src/main/java/org/openhab/binding/hydrawise/internal/handler/HydrawiseControllerHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.hydrawise/src/main/resources/OH-INF/thing/channel-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Thanks @fwolter , i have addressed your latest review comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! |
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Addressed PR comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Address PR review comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Addressed PR comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Address PR review comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com>
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Addressed PR comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Address PR review comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
* [hydrawise] Migrated to new GraphQL based API Fixes openhab#7261 Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Addressed PR comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com> * Address PR review comments. Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Fixes #7261
This is a major refactoring of the cloud communication logic due to Hydrawise migrating to a new GraphQL based API about a year ago, breaking the existing binding. Users have been manually installing and testing this branch for about a year as i have dragged my feet getting a PR submitted.
Signed-off-by: Dan Cunningham dan@digitaldan.com