Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] Fix color lights sending numbers as strings #10960

Merged
merged 2 commits into from
Jul 12, 2021

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Jul 7, 2021

note, also includes (unrelated) update on the device list

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

marcelrv added 2 commits July 7, 2021 19:19
Update to the latest device list

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/issues-with-color-items/124325/27

@marcelrv marcelrv added the bug An unexpected problem or unintended behavior of an add-on label Jul 7, 2021
@marcelrv marcelrv requested a review from fwolter July 7, 2021 19:42
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks!

@kaikreuzer kaikreuzer added this to the 3.2 milestone Jul 12, 2021
@kaikreuzer kaikreuzer merged commit c0ab022 into openhab:main Jul 12, 2021
@kaikreuzer kaikreuzer changed the title [miio] fix color lights sending numbers as strings [miio] Fix color lights sending numbers as strings Jul 12, 2021
computergeek1507 pushed a commit to computergeek1507/openhab-addons that referenced this pull request Jul 13, 2021
* [miio] fix color lights sending numbers as strings

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv deleted the miio-maint-july-devices branch July 18, 2021 18:22
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
* [miio] fix color lights sending numbers as strings

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
* [miio] fix color lights sending numbers as strings

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [miio] fix color lights sending numbers as strings

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants