Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[prowl] Initial contribution #10967

Merged
merged 1 commit into from
Mar 13, 2022
Merged

[prowl] Initial contribution #10967

merged 1 commit into from
Mar 13, 2022

Conversation

octa22
Copy link
Contributor

@octa22 octa22 commented Jul 9, 2021

This is the binding for the Prowl (https://www.prowlapp.com) iOS push service.
It has been written from scratch and therefore it is not based on the original 1.x Prowl binding.
It has no other purpose than sending push messages to iOS devices.

Signed-off-by: Ondrej Pecta opecta@gmail.com

@octa22 octa22 added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged labels Jul 9, 2021
@octa22 octa22 requested a review from a team as a code owner July 9, 2021 22:10
wborn
wborn reviewed Mar 7, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some comments you might want to incorporate when you continue working on this. 👍

It also seems the binding is still missing from the BOM file in bom/openhab-addons/pom.xml and you can also add yourself to the CODEOWNERS file. 🙂

bundles/org.openhab.binding.prowl/pom.xml Outdated Show resolved Hide resolved
...ab.binding.prowl/src/main/java/org/openhab/binding/prowl/internal/ProwlBindingConstants.java Outdated Show resolved Hide resolved
...enhab.binding.prowl/src/main/java/org/openhab/binding/prowl/internal/ProwlConfiguration.java Outdated Show resolved Hide resolved
...org.openhab.binding.prowl/src/main/java/org/openhab/binding/prowl/internal/ProwlHandler.java Outdated Show resolved Hide resolved
...org.openhab.binding.prowl/src/main/java/org/openhab/binding/prowl/internal/ProwlHandler.java Outdated Show resolved Hide resolved
...org.openhab.binding.prowl/src/main/java/org/openhab/binding/prowl/internal/ProwlHandler.java Outdated Show resolved Hide resolved
...org.openhab.binding.prowl/src/main/java/org/openhab/binding/prowl/internal/ProwlHandler.java Outdated Show resolved Hide resolved
...nhab.binding.prowl/src/main/java/org/openhab/binding/prowl/internal/ProwlHandlerFactory.java Outdated Show resolved Hide resolved
...nhab.binding.prowl/src/main/java/org/openhab/binding/prowl/internal/action/ProwlActions.java Show resolved Hide resolved
@wborn wborn changed the title [WIP][prowl] Initial contribution for OH3 [WIP][prowl] Initial contribution Mar 7, 2022
@octa22 octa22 changed the title [WIP][prowl] Initial contribution [prowl] Initial contribution Mar 13, 2022
@wborn
Copy link
Member

wborn commented Mar 13, 2022

Thanks for addressing my comments @octa22! It seems a somfytahoma commit now also ended up on this branch. Can you remove it and also make SAT happy by adding a new line at the end of the readme?

@wborn wborn removed the work in progress A PR that is not yet ready to be merged label Mar 13, 2022
@octa22
Copy link
Contributor Author

octa22 commented Mar 13, 2022

Thanks @wborn , I hope that everything is OK now.

@wborn
Copy link
Member

wborn commented Mar 13, 2022

Can you also add the default translations to /OH-INF/i18n/prowl.properties so the texts can be translated using Crowdin? You can generate these using: mvn i18n:generate-default-translations

It is also possible to make the ThingActions texts translatable using @text/ identifiers. See for instance PushoverActions and pushover.properties.

@octa22
[prowl] Initial contribution
42421f8 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
wborn
wborn approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 👍 Let's merge it now everything has been addressed. 🚀

@wborn wborn merged commit 43fe75b into openhab:main Mar 13, 2022
@wborn wborn added this to the 3.3 milestone Mar 13, 2022
@wborn wborn mentioned this pull request Mar 13, 2022
Closed
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/oh3-prowl-support/111478/3

@jamesfawcett
Copy link

jamesfawcett commented Apr 21, 2022 •
edited
Loading

Hi @octa22

Would it be possible to get priority added to the prowl notifications?

For example in the OH1 bindings, we could use this format:

pushNotification("{key}", "Battery Alert - Battery low on z-wave device.\n\n ", 5 )

We had to pass the key again as the first input, then the message, and we could send priority 0 - 5. Each different number makes a different notification sound on an iOS device. It would be great if you knew a way for the new bindings to support this too?

@octa22 octa22 mentioned this pull request Apr 24, 2022
Merged
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Apr 27, 2022
@octa22 @NickWaterton
[prowl] Initial contribution (openhab#10967)
ff201de 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
@octa22 @andan67
[prowl] Initial contribution (openhab#10967)
83c50cc 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
andrasU pushed a commit to andrasU/openhab-addons that referenced this pull request Nov 12, 2022
@octa22 @andrasU
[prowl] Initial contribution (openhab#10967)
9cd88f5 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
psmedley pushed a commit to psmedley/openhab-addons that referenced this pull request Feb 23, 2023
@octa22 @psmedley
[prowl] Initial contribution (openhab#10967)
b431ee4 
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
3.3
Development

Successfully merging this pull request may close these issues.
4 participants
@octa22 @wborn @openhab-bot @jamesfawcett