[openweathermap] Semantics added to channel types #10972
Conversation
lolodomo
force-pushed
the
owm_semantics
branch
2 times, most recently
from
bf8a8f6 to
e0581fb
Compare
Skinah
added
the
enhancement
| @@ -399,6 +440,10 @@ | |||
| <label>Forecasted Temperature</label> | |||
| <description>Forecasted outdoor temperature.</description> | |||
| <category>Temperature</category> | |||
| <tags> | |||
| <tag>Measurement</tag> | |||
There was a problem hiding this comment.
I am wondering here: A forecast is not really a measurement. I'd therefore rather refrain from adding this tag.
We might want to think of something like a "forecast" tag for the tag library instead. Wdyt?
There was a problem hiding this comment.
You're right, a forecast is not exactly a measurement.
I will add a new Point "Forecast" in the semantics tag.
There was a problem hiding this comment.
I am going to replace "Measurement" by "Status" for forecast channels as semantics library is frozen.
|
I'd suggest we park this PR until we finish the discussion on openhab/openhab-core#1791. Putting "Status" on everything where we don't have dedicated semantic tags for does not feel right to me and I wouldn't want to see this to be done for 300+ bindings now... |
|
@kaikreuzer : to make progress, I propose to only keep tags that are obvious (in particular measurements like temperature, humidity, pressure, ...) and suppress "Status" where we don't have dedicated semantic tags. Can we at least do that ? |
cweitkamp
added
the
awaiting feedback
|
@cweitkamp : the "awaiting feedback" is for @kaikreuzer , right ? |
|
Kind of. It is more or less feedback from discussion in openhab/openhab-core#1791. Didn't find a proper label for it. |
|
Sorry for dropping the ball here. 😩
Yes, let's do that, please! |
lolodomo
removed
the
awaiting feedback
Also fix few categories to use only official categories Signed-off-by: Laurent Garnier <lg.hc@free.fr>
lolodomo
force-pushed
the
owm_semantics
branch
from
b37e1c9 to
e1af272
Compare
|
@kaikreuzer : PR is updated. |
Also fix few categories to use only official categories Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
Also fix few categories to use only official categories Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Also fix few categories to use only official categories Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Also fix few categories to use only official categories Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Also fix few categories to use only official categories Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Also fix few categories to use only official categories
Signed-off-by: Laurent Garnier lg.hc@free.fr