Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[volvooncall] Extend battery channels #10991

Merged
merged 3 commits into from
Jul 18, 2021
Merged

[volvooncall] Extend battery channels #10991

merged 3 commits into from
Jul 18, 2021

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Jul 13, 2021 •
edited
Loading

Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.

@Jamstah Jamstah requested a review from clinique as a code owner July 13, 2021 10:06
clinique
clinique requested changes Jul 13, 2021
View reviewed changes
bundles/org.openhab.binding.volvooncall/example.events.txt Outdated Show resolved Hide resolved
...b.binding.volvooncall/src/main/java/org/openhab/binding/volvooncall/internal/dto/Status.java Outdated Show resolved Hide resolved
...b.binding.volvooncall/src/main/java/org/openhab/binding/volvooncall/internal/dto/Status.java Outdated Show resolved Hide resolved
...b.binding.volvooncall/src/main/java/org/openhab/binding/volvooncall/internal/dto/Status.java Outdated Show resolved Hide resolved
...b.binding.volvooncall/src/main/java/org/openhab/binding/volvooncall/internal/dto/Status.java Outdated Show resolved Hide resolved
...b.binding.volvooncall/src/main/java/org/openhab/binding/volvooncall/internal/dto/Status.java Outdated Show resolved Hide resolved
...b.binding.volvooncall/src/main/java/org/openhab/binding/volvooncall/internal/dto/Status.java Outdated Show resolved Hide resolved
...b.binding.volvooncall/src/main/java/org/openhab/binding/volvooncall/internal/dto/Status.java Outdated Show resolved Hide resolved
...inding.volvooncall/src/main/java/org/openhab/binding/volvooncall/internal/dto/HvBattery.java Show resolved Hide resolved
@Skinah Skinah added the enhancement An enhancement or new feature for an existing add-on label Jul 13, 2021
@Jamstah
Copy link
Contributor Author

Jamstah commented Jul 13, 2021

Long term it looks like Volvo are releasing a properly managed API: https://developer.volvocars.com/volvo-api/

I expect we'll need to switch to that in the future, but there are no battery values in there at all at the moment :(

@clinique
Copy link
Contributor

Long term it looks like Volvo are releasing a properly managed API: https://developer.volvocars.com/volvo-api/

I expect we'll need to switch to that in the future, but there are no battery values in there at all at the moment :(

It would be good because it was quite difficult to grab some specific informations on some aspects of the API answer. But unfortunately, I do not currently own a Volvo car anymore, so you'll have to take over on this.

@Jamstah
Copy link
Contributor Author

Jamstah commented Jul 13, 2021

Long term it looks like Volvo are releasing a properly managed API: https://developer.volvocars.com/volvo-api/
I expect we'll need to switch to that in the future, but there are no battery values in there at all at the moment :(

It would be good because it was quite difficult to grab some specific informations on some aspects of the API answer. But unfortunately, I do not currently own a Volvo car anymore, so you'll have to take over on this.

Do you want me to update codeowners to take it over, or add myself, or are you happy still providing reviews?

@clinique
Copy link
Contributor

Long term it looks like Volvo are releasing a properly managed API: https://developer.volvocars.com/volvo-api/
I expect we'll need to switch to that in the future, but there are no battery values in there at all at the moment :(

It would be good because it was quite difficult to grab some specific informations on some aspects of the API answer. But unfortunately, I do not currently own a Volvo car anymore, so you'll have to take over on this.

Do you want me to update codeowners to take it over, or add myself, or are you happy still providing reviews?

I'm still happy to provide reviews but will not initiate evolutions nor be able to test, so if you want to add yourself to codeowners you're more than welcome.

@Jamstah Jamstah requested a review from a team as a code owner July 13, 2021 13:10
@Jamstah
Copy link
Contributor Author

Jamstah commented Jul 13, 2021

I'll drop myself on there to help out, I get enough back from openhab that I should be doing some of the work :)

Not sure I'll find time to work with the new API - looks like we'd need to switch to an OIDC flow too, and I don't know how that fits with the openhab ui today - we must be doing it somewhere.

@Jamstah Jamstah force-pushed the voc-battery-channels branch 2 times, most recently from 4444561 to 3b3f894 Compare July 13, 2021 22:44
@kaikreuzer kaikreuzer added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Jul 15, 2021
@Jamstah Jamstah force-pushed the voc-battery-channels branch from 3b3f894 to ad41ebc Compare July 16, 2021 14:55
@Jamstah Jamstah force-pushed the voc-battery-channels branch from ad41ebc to d440494 Compare July 16, 2021 17:08
@Jamstah
Copy link
Contributor Author

Jamstah commented Jul 16, 2021

Sorry, forgot about that comment!

@Jamstah Jamstah force-pushed the voc-battery-channels branch from d440494 to 608d93e Compare July 16, 2021 22:30
Jamstah added 2 commits July 16, 2021 23:32
@Jamstah
[volvooncall] Extend battery channels
31be0d0 
Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.

Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
@Jamstah
[volvooncall] Add myself as a voc maintainer
6a66ade 
Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
@Jamstah Jamstah force-pushed the voc-battery-channels branch from 608d93e to 6a66ade Compare July 16, 2021 22:32
clinique
clinique approved these changes Jul 17, 2021
View reviewed changes
Copy link
Contributor

@clinique clinique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clinique clinique requested a review from lolodomo July 17, 2021 07:02
@Jamstah Jamstah force-pushed the voc-battery-channels branch from 3d3d9ca to 6d77a55 Compare July 18, 2021 14:41
@Jamstah
[volvooncall] Thing label review
5af9036 
Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
@Jamstah Jamstah force-pushed the voc-battery-channels branch from 6d77a55 to 5af9036 Compare July 18, 2021 14:42
kaikreuzer
kaikreuzer approved these changes Jul 18, 2021
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@kaikreuzer kaikreuzer merged commit fcc23f0 into openhab:main Jul 18, 2021
@kaikreuzer kaikreuzer added this to the 3.2 milestone Jul 18, 2021
dw-8 pushed a commit to dw-8/openhab-addons that referenced this pull request Jul 23, 2021
@Jamstah @dw-8
[volvooncall] Extend battery channels (openhab#10991)
3ea5dbc 
* [volvooncall] Extend battery channels

Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.

Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8 pushed a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
@Jamstah @dw-8
[volvooncall] Extend battery channels (openhab#10991)
b3c4bee 
* [volvooncall] Extend battery channels

Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.

Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8 added a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
@dw-8
Revert "[volvooncall] Extend battery channels (openhab#10991)"
089d997 
This reverts commit b3c4bee.
dw-8 pushed a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
@Jamstah @dw-8
[volvooncall] Extend battery channels (openhab#10991)
381cc17 
* [volvooncall] Extend battery channels

Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.

Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8 added a commit to dw-8/openhab-addons that referenced this pull request Jul 25, 2021
@dw-8
Revert "[volvooncall] Extend battery channels (openhab#10991)"
684e55b 
This reverts commit b3c4bee.

Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
@Jamstah @frederictobiasc
[volvooncall] Extend battery channels (openhab#10991)
4206465 
* [volvooncall] Extend battery channels

Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.

Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
thinkingstone pushed a commit to thinkingstone/openhab-addons that referenced this pull request Nov 7, 2021
@Jamstah @thinkingstone
[volvooncall] Extend battery channels (openhab#10991)
faa33a0 
* [volvooncall] Extend battery channels

Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.

Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
@Jamstah
[volvooncall] Extend battery channels (openhab#10991)
fafb74d 
* [volvooncall] Extend battery channels

Add some convenience channels for charging status and handle the battery level carefully because the API can be misleading.

Signed-off-by: James Hewitt-Thomas <james.hewitt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinique clinique clinique approved these changes

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@lolodomo lolodomo Awaiting requested review from lolodomo

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Jamstah @clinique @kaikreuzer @Skinah