[homeassistant/homie] Standardize config URI #11021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
kaikreuzer
requested changes
Jul 18, 2021
| @@ -29,5 +29,5 @@ | |||
| // List of all Thing Type UIDs | |||
| public static final ThingTypeUID HOMEASSISTANT_MQTT_THING = new ThingTypeUID(BINDING_ID, "homeassistant"); | |||
|
|
|||
| public static final String CONFIG_HA_CHANNEL = "mqtt:ha_channel"; | |||
| public static final String CONFIG_HA_CHANNEL = "channel-type:homeassistant:mqtt-channel"; | |||
There was a problem hiding this comment.
The binding here is MQTT, so shouldn't it be channel-type:mqtt:ha_channel?
There was a problem hiding this comment.
Ok, I changed in favor of channel-type:mqtt:ha-channel and channel-type:mqtt:homie-channel
Signed-off-by: Laurent Garnier <lg.hc@free.fr>
dw-8
pushed a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
* [homeassistant/homie] Standardize config URI Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8
added a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
This reverts commit 58024c4.
dw-8
pushed a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
* [homeassistant/homie] Standardize config URI Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8
added a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
This reverts commit 58024c4. Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8
pushed a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
* [homeassistant/homie] Standardize config URI Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8
added a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
This reverts commit ebbc17d.
dw-8
pushed a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
* [homeassistant/homie] Standardize config URI Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
dw-8
added a commit
to dw-8/openhab-addons
that referenced
this pull request
Jul 25, 2021
This reverts commit ebbc17d. Signed-off-by: dw-8 <davy.wong.on+github@gmail.com>
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
* [homeassistant/homie] Standardize config URI Signed-off-by: Laurent Garnier <lg.hc@free.fr>
thinkingstone
pushed a commit
to thinkingstone/openhab-addons
that referenced
this pull request
Nov 7, 2021
* [homeassistant/homie] Standardize config URI Signed-off-by: Laurent Garnier <lg.hc@free.fr>
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
* [homeassistant/homie] Standardize config URI Signed-off-by: Laurent Garnier <lg.hc@free.fr> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [homeassistant/homie] Standardize config URI Signed-off-by: Laurent Garnier <lg.hc@free.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier lg.hc@free.fr