-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AirQuality] Tagging channels, prepared for Crowdin, dynamic channels #11192
Conversation
It's a common pattern to have a bridge for the credentials. The advantage over holding the credentials at binding level is that you can have multiple accounts configured. It's also beneficial for the usability when the configuration is consistent across bindings. You already encapsulated the common API communication code in a separate class, which is good design. So, I'd like to encourage you to pull that design through and do this for the configuration, too. |
Adding alert level and code refined. Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Added measures for each pollutant. Added extensible channel for pollutant sensibility. Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gael L'hopital <gael@lhopital.org>
Signed-off-by: clinique <gael@lhopital.org>
6e30c92
to
e406ce3
Compare
Ok, done. |
...rquality/src/main/java/org/openhab/binding/airquality/internal/AirQualityHandlerFactory.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.airquality/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: clinique <gael@lhopital.org>
The French properties file has to be loaded in Crowdin. |
Done |
…openhab#11192) * Adding semantic tags Adding alert level and code refined. Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Commiting intermediate work Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Complete review of the binding. Added measures for each pollutant. Added extensible channel for pollutant sensibility. Signed-off-by: clinique <gael@lhopital.org> * Finishing translation Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One last code cleansing to be ready to push Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Documentation updates Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Spotless apply Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Correcting conflicting file Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Code review correction Signed-off-by: Gael L'hopital <gael@lhopital.org> * Introducing a bridge to Api Signed-off-by: clinique <gael@lhopital.org> * Code review correction Signed-off-by: clinique <gael@lhopital.org>
…openhab#11192) * Adding semantic tags Adding alert level and code refined. Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Commiting intermediate work Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Complete review of the binding. Added measures for each pollutant. Added extensible channel for pollutant sensibility. Signed-off-by: clinique <gael@lhopital.org> * Finishing translation Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One last code cleansing to be ready to push Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Documentation updates Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Spotless apply Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Correcting conflicting file Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Code review correction Signed-off-by: Gael L'hopital <gael@lhopital.org> * Introducing a bridge to Api Signed-off-by: clinique <gael@lhopital.org> * Code review correction Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
…openhab#11192) * Adding semantic tags Adding alert level and code refined. Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Commiting intermediate work Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Complete review of the binding. Added measures for each pollutant. Added extensible channel for pollutant sensibility. Signed-off-by: clinique <gael@lhopital.org> * Finishing translation Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One last code cleansing to be ready to push Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Documentation updates Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Spotless apply Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Correcting conflicting file Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Code review correction Signed-off-by: Gael L'hopital <gael@lhopital.org> * Introducing a bridge to Api Signed-off-by: clinique <gael@lhopital.org> * Code review correction Signed-off-by: clinique <gael@lhopital.org> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
…openhab#11192) * Adding semantic tags Adding alert level and code refined. Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Commiting intermediate work Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Complete review of the binding. Added measures for each pollutant. Added extensible channel for pollutant sensibility. Signed-off-by: clinique <gael@lhopital.org> * Finishing translation Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One last code cleansing to be ready to push Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Documentation updates Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Spotless apply Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Correcting conflicting file Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Code review correction Signed-off-by: Gael L'hopital <gael@lhopital.org> * Introducing a bridge to Api Signed-off-by: clinique <gael@lhopital.org> * Code review correction Signed-off-by: clinique <gael@lhopital.org>
…openhab#11192) * Adding semantic tags Adding alert level and code refined. Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Commiting intermediate work Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Complete review of the binding. Added measures for each pollutant. Added extensible channel for pollutant sensibility. Signed-off-by: clinique <gael@lhopital.org> * Finishing translation Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One last code cleansing to be ready to push Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Documentation updates Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Spotless apply Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Correcting conflicting file Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Code review correction Signed-off-by: Gael L'hopital <gael@lhopital.org> * Introducing a bridge to Api Signed-off-by: clinique <gael@lhopital.org> * Code review correction Signed-off-by: clinique <gael@lhopital.org>
…openhab#11192) * Adding semantic tags Adding alert level and code refined. Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Commiting intermediate work Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Complete review of the binding. Added measures for each pollutant. Added extensible channel for pollutant sensibility. Signed-off-by: clinique <gael@lhopital.org> * Finishing translation Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One last code cleansing to be ready to push Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Documentation updates Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Spotless apply Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Correcting conflicting file Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Code review correction Signed-off-by: Gael L'hopital <gael@lhopital.org> * Introducing a bridge to Api Signed-off-by: clinique <gael@lhopital.org> * Code review correction Signed-off-by: clinique <gael@lhopital.org>
With this upgrade you'll find :