Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AirQuality] Tagging channels, prepared for Crowdin, dynamic channels #11192

Merged
merged 11 commits into from
Nov 9, 2021

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Sep 2, 2021

With this upgrade you'll find :

  • Tagged channels
  • A new pictogram channel based on the AQI value
  • Pollutant channels are now dynamic, depending upon capabilities of the station
  • Dynamic channels can be defined to set a warning based on specific sensitive groups toward the dominent pollutant
  • Per pollutant, the binding calculates the actual QuantityType associated to a given AQI value (e.g. AQI 13 => 18,4 ppm)
  • The binding has been adapted to be able to take benefits of Crowdin translations
  • Some additional weather channels are available (dew-point, wind-speed).

@fwolter
Copy link
Member

fwolter commented Nov 6, 2021

It's a common pattern to have a bridge for the credentials. The advantage over holding the credentials at binding level is that you can have multiple accounts configured. It's also beneficial for the usability when the configuration is consistent across bindings.

You already encapsulated the common API communication code in a separate class, which is good design. So, I'd like to encourage you to pull that design through and do this for the configuration, too.

Adding alert level and code refined.

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Added measures for each pollutant.
Added extensible channel for pollutant sensibility.

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gael L'hopital <gael@lhopital.org>
@wborn wborn removed this from the 3.2 milestone Nov 7, 2021
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Copy link
Contributor Author

clinique commented Nov 8, 2021

It's a common pattern to have a bridge for the credentials. The advantage over holding the credentials at binding level is that you can have multiple accounts configured. It's also beneficial for the usability when the configuration is consistent across bindings.

You already encapsulated the common API communication code in a separate class, which is good design. So, I'd like to encourage you to pull that design through and do this for the configuration, too.

Ok, done.

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique changed the title [AirQuality] Tagging channels, prepared for Crowin, dynamic channels [AirQuality] Tagging channels, prepared for Crowdin, dynamic channels Nov 8, 2021
@clinique clinique requested a review from fwolter November 8, 2021 23:27
@fwolter fwolter merged commit 7bd71fd into openhab:main Nov 9, 2021
@fwolter fwolter added this to the 3.2 milestone Nov 9, 2021
@lolodomo
Copy link
Contributor

lolodomo commented Nov 9, 2021

The French properties file has to be loaded in Crowdin.

@lolodomo
Copy link
Contributor

lolodomo commented Nov 9, 2021

The French properties file has to be loaded in Crowdin.

Done

jpg0 pushed a commit to jpg0/openhab-addons that referenced this pull request Nov 10, 2021
…openhab#11192)

* Adding semantic tags
Adding alert level and code refined.

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Commiting intermediate work

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Complete review of the binding.
Added measures for each pollutant.
Added extensible channel for pollutant sensibility.

Signed-off-by: clinique <gael@lhopital.org>

* Finishing translation

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* One last code cleansing to be ready to push

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Documentation updates

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Spotless apply

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Correcting conflicting file

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Code review correction

Signed-off-by: Gael L'hopital <gael@lhopital.org>

* Introducing a bridge to Api

Signed-off-by: clinique <gael@lhopital.org>

* Code review correction

Signed-off-by: clinique <gael@lhopital.org>
@clinique clinique deleted the AirQualityTags branch November 16, 2021 09:08
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
…openhab#11192)

* Adding semantic tags
Adding alert level and code refined.

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Commiting intermediate work

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Complete review of the binding.
Added measures for each pollutant.
Added extensible channel for pollutant sensibility.

Signed-off-by: clinique <gael@lhopital.org>

* Finishing translation

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* One last code cleansing to be ready to push

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Documentation updates

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Spotless apply

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Correcting conflicting file

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Code review correction

Signed-off-by: Gael L'hopital <gael@lhopital.org>

* Introducing a bridge to Api

Signed-off-by: clinique <gael@lhopital.org>

* Code review correction

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…openhab#11192)

* Adding semantic tags
Adding alert level and code refined.

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Commiting intermediate work

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Complete review of the binding.
Added measures for each pollutant.
Added extensible channel for pollutant sensibility.

Signed-off-by: clinique <gael@lhopital.org>

* Finishing translation

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* One last code cleansing to be ready to push

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Documentation updates

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Spotless apply

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Correcting conflicting file

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Code review correction

Signed-off-by: Gael L'hopital <gael@lhopital.org>

* Introducing a bridge to Api

Signed-off-by: clinique <gael@lhopital.org>

* Code review correction

Signed-off-by: clinique <gael@lhopital.org>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
…openhab#11192)

* Adding semantic tags
Adding alert level and code refined.

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Commiting intermediate work

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Complete review of the binding.
Added measures for each pollutant.
Added extensible channel for pollutant sensibility.

Signed-off-by: clinique <gael@lhopital.org>

* Finishing translation

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* One last code cleansing to be ready to push

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Documentation updates

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Spotless apply

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Correcting conflicting file

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Code review correction

Signed-off-by: Gael L'hopital <gael@lhopital.org>

* Introducing a bridge to Api

Signed-off-by: clinique <gael@lhopital.org>

* Code review correction

Signed-off-by: clinique <gael@lhopital.org>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…openhab#11192)

* Adding semantic tags
Adding alert level and code refined.

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Commiting intermediate work

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Complete review of the binding.
Added measures for each pollutant.
Added extensible channel for pollutant sensibility.

Signed-off-by: clinique <gael@lhopital.org>

* Finishing translation

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* One last code cleansing to be ready to push

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Documentation updates

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Spotless apply

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Correcting conflicting file

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Code review correction

Signed-off-by: Gael L'hopital <gael@lhopital.org>

* Introducing a bridge to Api

Signed-off-by: clinique <gael@lhopital.org>

* Code review correction

Signed-off-by: clinique <gael@lhopital.org>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…openhab#11192)

* Adding semantic tags
Adding alert level and code refined.

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Commiting intermediate work

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Complete review of the binding.
Added measures for each pollutant.
Added extensible channel for pollutant sensibility.

Signed-off-by: clinique <gael@lhopital.org>

* Finishing translation

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* One last code cleansing to be ready to push

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Documentation updates

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Spotless apply

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Correcting conflicting file

Signed-off-by: Gaël L'hopital <gael@lhopital.org>

* Code review correction

Signed-off-by: Gael L'hopital <gael@lhopital.org>

* Introducing a bridge to Api

Signed-off-by: clinique <gael@lhopital.org>

* Code review correction

Signed-off-by: clinique <gael@lhopital.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on (potentially) not backward compatible translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants