[feed] added channel for enclosure link on latest entry #11257
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juergen Pabel <juergen@pabel.net>
…-addons into feed_enclosure-link
Skinah
added
the
enhancement
|
Please add your new channel in the documentation and please sign-off your PR. |
Signed-off-by: Juergen Pabel <juergen@pabel.net>
Signed-off-by: Kai Kreuzer <kai@openhab.org> Signed-off-by: Juergen Pabel <juergen@pabel.net>
Signed-off-by: Juergen Pabel <juergen@pabel.net>
Signed-off-by: Juergen Pabel <juergen@pabel.net>
…-addons into feed_enclosure-link
|
Gnahh....included commit https://github.com/juergenpabel/openhab-addons/commit/195d532aa770aa69e78d103322fabe4a0295f96f from Kai in rebase signoff. Please ignore (wouldn't be merged anyhow) |
|
Closing this PR in favor of (#11345) for cleanliness sake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feed] added channel for enclosure link on latest entry
The feed plugin doesn't support (most) podcasts, as the audio link is provided in an enclosure tag; this PR adds the new channel "lastest-enclosure" to the thing. Albeit multiple enclosures are supported, this thing exposes only the first enclosure (if any at all - else the channel will be UNDEF). This covers the vast majority of podcasts sufficiently while minimizing the changes to the binding (a general re-refactoring/improvement of this binding would seem to be reasonable, though).