[tr064] Fix incorrectly reported decibel values for DSL Noise Margin and Attenuation #11337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and Attenuation Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
lolodomo
requested changes
Oct 9, 2021
....binding.tr064/src/main/java/org/openhab/binding/tr064/internal/soap/SOAPValueConverter.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
lolodomo
added
rebuild
|
Build failed due to timeout. |
lolodomo
added
rebuild
frederictobiasc
pushed a commit
to frederictobiasc/openhab-addons
that referenced
this pull request
Oct 26, 2021
…and Attenuation (openhab#11337) * [tr064] fix incorrectly reported decibel values for DSL Noise Margin and Attenuation Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> * apply review feedback Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
…and Attenuation (openhab#11337) * [tr064] fix incorrectly reported decibel values for DSL Noise Margin and Attenuation Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> * apply review feedback Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…and Attenuation (openhab#11337) * [tr064] fix incorrectly reported decibel values for DSL Noise Margin and Attenuation Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> * apply review feedback Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…and Attenuation (openhab#11337) * [tr064] fix incorrectly reported decibel values for DSL Noise Margin and Attenuation Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> * apply review feedback Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…and Attenuation (openhab#11337) * [tr064] fix incorrectly reported decibel values for DSL Noise Margin and Attenuation Signed-off-by: Stefan Giehl <stefangiehl@gmail.com> * apply review feedback Signed-off-by: Stefan Giehl <stefangiehl@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in #10783, the decibel values reported for the DSL Noise Margin and DSL Attenuation channels are currently reported with a 10 times too high value.
I tried simply using
dadB(deca-decibel) as unit in thechannels.xml, but that doesn't work an results in an Exception likejava.lang.IllegalArgumentException: Invalid Quantity value: 150 dadBSo guess using a post processor might be the most easiest solution to "fix" those values.
fixes #10783