Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mikrotik] WiFi client logging and presence problem fix #11386

Merged
merged 2 commits into from
Oct 17, 2021

Conversation

duhast
Copy link
Member

@duhast duhast commented Oct 14, 2021

WiFi client logging and presence problem fix

Community thread report

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/mikrotik-routeros-binding-arrived/115241/24

@duhast
Copy link
Member Author

duhast commented Oct 14, 2021

Hi @fwolter !
Please review at your earliest convenience.

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Oct 17, 2021
@fwolter fwolter added this to the 3.2 milestone Oct 17, 2021
@fwolter fwolter changed the title [mikrotik] WiFi client fix [mikrotik] WiFi client logging and presence problem fix Oct 17, 2021
@fwolter fwolter merged commit 27886d7 into openhab:main Oct 17, 2021
@duhast
Copy link
Member Author

duhast commented Oct 17, 2021

Thanks! I'd appreciate if you'll take a look at this PR as well.

@duhast duhast deleted the mikrotik/wifi-cli branch October 17, 2021 12:12
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
* [mikrotik] WiFi client fix

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>

* [mikrotik] Thing types and WiFi client presence update

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
* [mikrotik] WiFi client fix

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>

* [mikrotik] Thing types and WiFi client presence update

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
* [mikrotik] WiFi client fix

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>

* [mikrotik] Thing types and WiFi client presence update

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* [mikrotik] WiFi client fix

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>

* [mikrotik] Thing types and WiFi client presence update

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* [mikrotik] WiFi client fix

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>

* [mikrotik] Thing types and WiFi client presence update

Signed-off-by: Oleg Vivtash <oleg@vivtash.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants