Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[orbitbhyve] Fixed updating of watering time channel #11388

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

octa22
Copy link
Contributor

@octa22 octa22 commented Oct 14, 2021

This PR fixes the broken initialization of watering time channel.
I noticed it got broken in changes related to the code review comments.

Signed-off-by: Ondřej Pečta opecta@gmail.com

@octa22 octa22 added the bug An unexpected problem or unintended behavior of an add-on label Oct 14, 2021
@octa22 octa22 force-pushed the orbitbhyve-pr branch 2 times, most recently from e83adbf to 98a1b40 Compare October 14, 2021 20:05
Signed-off-by: Ondrej Pecta <opecta@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octa22 octa22 added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 17, 2021
@lolodomo
Copy link
Contributor

Code change is very small and the build of the binding is successful on my local machine, so I merge the PR while the remote build system is currently broken.

@lolodomo lolodomo merged commit 6a33a3f into openhab:main Oct 18, 2021
@lolodomo lolodomo added this to the 3.2 milestone Oct 18, 2021
frederictobiasc pushed a commit to frederictobiasc/openhab-addons that referenced this pull request Oct 26, 2021
Signed-off-by: Ondrej Pecta <opecta@gmail.com>

Co-authored-by: Ondřej Pečta <pecta@Ondrej-MacBook-Pro.local>
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
Signed-off-by: Ondrej Pecta <opecta@gmail.com>

Co-authored-by: Ondřej Pečta <pecta@Ondrej-MacBook-Pro.local>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
@wborn wborn changed the title [orbitbhyve] fixed updating of watering time channel [orbitbhyve] Fixed updating of watering time channel Dec 18, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
Signed-off-by: Ondrej Pecta <opecta@gmail.com>

Co-authored-by: Ondřej Pečta <pecta@Ondrej-MacBook-Pro.local>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
Signed-off-by: Ondrej Pecta <opecta@gmail.com>

Co-authored-by: Ondřej Pečta <pecta@Ondrej-MacBook-Pro.local>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
Signed-off-by: Ondrej Pecta <opecta@gmail.com>

Co-authored-by: Ondřej Pečta <pecta@Ondrej-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants