-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[verisure] Keep refreshing after RuntimeException #11397
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
lolodomo
reviewed
Oct 17, 2021
...isure/src/main/java/org/openhab/binding/verisure/internal/handler/VerisureBridgeHandler.java
Outdated
Show resolved
Hide resolved
lolodomo
changed the title
Fix that binding stops refreshing after RuntimException (#11396)
[verisure] Keep refreshing after RuntimException (#11396)
Oct 17, 2021
lolodomo
added
rebuild
Triggers Jenkins PR build
and removed
rebuild
Triggers Jenkins PR build
labels
Oct 17, 2021
wborn
changed the title
[verisure] Keep refreshing after RuntimException (#11396)
[verisure] Keep refreshing after RuntimException
Oct 29, 2021
wborn
changed the title
[verisure] Keep refreshing after RuntimException
[verisure] Keep refreshing after RuntimeException
Oct 29, 2021
lolodomo
requested changes
Oct 30, 2021
...isure/src/main/java/org/openhab/binding/verisure/internal/handler/VerisureBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
lolodomo
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
* Fix that binding stops refreshing after RuntimException (openhab#11396) Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after review comments Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
jpg0
pushed a commit
to jpg0/openhab-addons
that referenced
this pull request
Nov 10, 2021
* Fix that binding stops refreshing after RuntimException (openhab#11396) Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after review comments Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Fix that binding stops refreshing after RuntimException (openhab#11396) Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after review comments Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Fix that binding stops refreshing after RuntimException (openhab#11396) Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after review comments Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Fix that binding stops refreshing after RuntimException (openhab#11396) Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after review comments Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
* Fix that binding stops refreshing after RuntimException (openhab#11396) Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com> * Updated after review comments Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #11396 - Runtime exception not caught causing periodic refresh to stop.
The binding does not handle a RuntimeException correctly which leads to that the binding stops to refresh, which this PR fixes.
Signed-off-by: Jan Gustafsson jannegpriv@gmail.com