Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[verisure] Keep refreshing after RuntimeException #11397

Merged
merged 2 commits into from
Oct 31, 2021

Conversation

jannegpriv
Copy link
Contributor

Fix for #11396 - Runtime exception not caught causing periodic refresh to stop.

The binding does not handle a RuntimeException correctly which leads to that the binding stops to refresh, which this PR fixes.

Signed-off-by: Jan Gustafsson jannegpriv@gmail.com

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
@lolodomo lolodomo added the bug An unexpected problem or unintended behavior of an add-on label Oct 17, 2021
@lolodomo lolodomo changed the title Fix that binding stops refreshing after RuntimException (#11396) [verisure] Keep refreshing after RuntimException (#11396) Oct 17, 2021
@lolodomo lolodomo added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels Oct 17, 2021
@wborn wborn changed the title [verisure] Keep refreshing after RuntimException (#11396) [verisure] Keep refreshing after RuntimException Oct 29, 2021
@wborn wborn changed the title [verisure] Keep refreshing after RuntimException [verisure] Keep refreshing after RuntimeException Oct 29, 2021
Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lolodomo lolodomo merged commit ba9d8b3 into openhab:main Oct 31, 2021
@lolodomo lolodomo added this to the 3.2 milestone Oct 31, 2021
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
* Fix that binding stops refreshing after RuntimException (openhab#11396)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after review comments

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
jpg0 pushed a commit to jpg0/openhab-addons that referenced this pull request Nov 10, 2021
* Fix that binding stops refreshing after RuntimException (openhab#11396)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after review comments

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
* Fix that binding stops refreshing after RuntimException (openhab#11396)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after review comments

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* Fix that binding stops refreshing after RuntimException (openhab#11396)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after review comments

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Fix that binding stops refreshing after RuntimException (openhab#11396)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after review comments

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Fix that binding stops refreshing after RuntimException (openhab#11396)

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>

* Updated after review comments

Signed-off-by: Jan Gustafsson <jannegpriv@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[verisure] Runtime exception not caught causing periodic refresh to stop
2 participants