[linky] Correcting authentication bug #11406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: clinique <gael@lhopital.org>
lolodomo
requested changes
Oct 18, 2021
...penhab.binding.linky/src/main/java/org/openhab/binding/linky/internal/api/EnedisHttpApi.java
Outdated
Show resolved
Hide resolved
|
After fixing the problem with feature.xml, build succeeded. jar deployed and the thing is now ONLINE and channels have data. |
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
|
One point remaining before I approve: the if condition related to username. Sorry for confusion I probably introduced. |
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
lolodomo
requested changes
Oct 19, 2021
...enhab.binding.linky/src/main/java/org/openhab/binding/linky/internal/LinkyConfiguration.java
Outdated
Show resolved
Hide resolved
...penhab.binding.linky/src/main/java/org/openhab/binding/linky/internal/api/EnedisHttpApi.java
Outdated
Show resolved
Hide resolved
...hab.binding.linky/src/main/java/org/openhab/binding/linky/internal/handler/LinkyHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
kaikreuzer
added
rebuild
|
@clinique : you should check that username, password and authId are not blank too. Because if they are, this will not work. |
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
|
Build succeeded |
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
* Correcting authentication bug (issue openhab#10360) Signed-off-by: clinique <gael@lhopital.org> * Reverting PR openhab#11233 & PR openhab#11266 Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Addressing @lolodomo feed-back Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One pointless comment left Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Adding missing test on username Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Reviewing configuration elements nullness and empty checks. Signed-off-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
* Correcting authentication bug (issue openhab#10360) Signed-off-by: clinique <gael@lhopital.org> * Reverting PR openhab#11233 & PR openhab#11266 Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Addressing @lolodomo feed-back Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One pointless comment left Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Adding missing test on username Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Reviewing configuration elements nullness and empty checks. Signed-off-by: Gaël L'hopital <gael@lhopital.org> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
* Correcting authentication bug (issue openhab#10360) Signed-off-by: clinique <gael@lhopital.org> * Reverting PR openhab#11233 & PR openhab#11266 Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Addressing @lolodomo feed-back Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One pointless comment left Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Adding missing test on username Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Reviewing configuration elements nullness and empty checks. Signed-off-by: Gaël L'hopital <gael@lhopital.org>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* Correcting authentication bug (issue openhab#10360) Signed-off-by: clinique <gael@lhopital.org> * Reverting PR openhab#11233 & PR openhab#11266 Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Addressing @lolodomo feed-back Signed-off-by: Gaël L'hopital <gael@lhopital.org> * One pointless comment left Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Adding missing test on username Signed-off-by: Gaël L'hopital <gael@lhopital.org> * Reviewing configuration elements nullness and empty checks. Signed-off-by: Gaël L'hopital <gael@lhopital.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #10360
Signed-off-by: clinique gael@lhopital.org