[digitalstrom] Fix: Remove excessive log statements for unknown Application Groups #11433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Groups Signed-off-by: Rouven Schürch <r.schuerch@gmx.ch>
ardanedh
changed the title
|
I imagine this warning was introduced for a reason. Rather than removing it, wouldn't it make sense to rather reduce its level to DEBUG (or even TRACE) ? Like that, it will not be logged for standard users. |
|
Actually, the log statement had been introduced by me, under the impression of being a good idea - which it was not. At the time of writing my digitalSTROM installation consisted of a few items, the log statement was negligible, now running a few items more, the log spam is considerable. |
|
Ok |
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
…icationGroups (openhab#11433) Signed-off-by: Rouven Schürch <r.schuerch@gmx.ch> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
wborn
changed the title
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…icationGroups (openhab#11433) Signed-off-by: Rouven Schürch <r.schuerch@gmx.ch> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…icationGroups (openhab#11433) Signed-off-by: Rouven Schürch <r.schuerch@gmx.ch>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…icationGroups (openhab#11433) Signed-off-by: Rouven Schürch <r.schuerch@gmx.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10939, excessive log statements. The occurence of the unknown Application Groups is still unclear and a first try to squelch the logging messages failed.
The WARN log statement has been removed competely as there is no means of correcting the digitalSTROM configuration on the DSS or in the binding.
Signed-off-by: Rouven Schürch r.schuerch@gmx.ch