[jsscripting] Update GraalJS to 21.3 to allow method selection via JavaScript #11437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ript Signed-off-by: Lukas Agethen <lukas83@gmx.de>
kaikreuzer
added
rebuild
wborn
changed the title
|
Anything else needed for review from my side? |
|
I just tested this on my system and everything works as expected, so @LukasA83 the upgrade allows Graaljs to pick |
|
Well it allows you to define in case there is a conflict, see |
|
Maybe @jpg0 can give his review, but this LGTM |
|
What else is required to get this PR merged? |
wborn
approved these changes
Nov 6, 2021
dschoepel
pushed a commit
to dschoepel/openhab-addons
that referenced
this pull request
Nov 9, 2021
…vaScript (openhab#11437) Signed-off-by: Lukas Agethen <lukas83@gmx.de> Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
jpg0
pushed a commit
to jpg0/openhab-addons
that referenced
this pull request
Nov 10, 2021
…vaScript (openhab#11437) Signed-off-by: Lukas Agethen <lukas83@gmx.de>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…vaScript (openhab#11437) Signed-off-by: Lukas Agethen <lukas83@gmx.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…vaScript (openhab#11437) Signed-off-by: Lukas Agethen <lukas83@gmx.de> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…vaScript (openhab#11437) Signed-off-by: Lukas Agethen <lukas83@gmx.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…vaScript (openhab#11437) Signed-off-by: Lukas Agethen <lukas83@gmx.de>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…vaScript (openhab#11437) Signed-off-by: Lukas Agethen <lukas83@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow method selection via javascript in case of graaljs unable to choose right method by itself, Graaljs needed to be updated to >21, e.g. for events.postUpdate with item and state when state is a DecimalType.
Signed-off-by: Lukas Agethen lukas83@gmx.de