Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openhabcloud] Added default i18n properties file #11547

Merged
merged 2 commits into from
Nov 8, 2021

Conversation

cweitkamp
Copy link
Contributor

  • Added default i18n properties file

@wborn Thanks for adding support in your i18n plugin to translate other bundles too. Lets try if it is working like expected.

Signed-off-by: Christoph Weitkamp github@christophweitkamp.de

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@wborn
Copy link
Member

wborn commented Nov 8, 2021

The plugin doesn't add names for services.
Hopefully it works similarly like in OHC where we use:

service.system.voice.label = Voice

So perhaps using service.io.openhabcloud.label as key also works?

@@ -0,0 +1,10 @@
# bundle config
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ftr: this comment was added by me manually.

@cweitkamp
Copy link
Contributor Author

So perhaps using service.io.openhabcloud.label as key also works?

Yes, that should work. Notation is either service.<uri>.label = ... (: has to be replaced by . in the <uri> part) or @text/<key> (see openhab/openhab-core#2333).

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Now you can hopefully translate Cloud to Wolke everywhere, although I don't know if that is a good idea. 😉

@wborn wborn merged commit dfe577a into openhab:main Nov 8, 2021
@cweitkamp cweitkamp deleted the feature-openhabcloud-default-i18n branch November 8, 2021 11:59
dschoepel pushed a commit to dschoepel/openhab-addons that referenced this pull request Nov 9, 2021
* Added default i18n properties file
* Added translation property for service label

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Dave J Schoepel <dave@theschoepels.com>
jpg0 pushed a commit to jpg0/openhab-addons that referenced this pull request Nov 10, 2021
* Added default i18n properties file
* Added translation property for service label

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
@wborn wborn added this to the 3.2 milestone Nov 10, 2021
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
* Added default i18n properties file
* Added translation property for service label

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
* Added default i18n properties file
* Added translation property for service label

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
* Added default i18n properties file
* Added translation property for service label

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
* Added default i18n properties file
* Added translation property for service label

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
* Added default i18n properties file
* Added translation property for service label

Signed-off-by: Christoph Weitkamp <github@christophweitkamp.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants