[MQTT.Homeassistant] Make the mqtt.vacuum compliant #11562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the specification Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
cweitkamp
added
the
enhancement
fwolter
approved these changes
Nov 20, 2021
|
You could set yourself as the code owner in the |
Do I need to create a PR for this? |
|
Yes. |
wborn
changed the title
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…th the specification (openhab#11562) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…th the specification (openhab#11562) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…th the specification (openhab#11562) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…th the specification (openhab#11562) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…th the specification (openhab#11562) Signed-off-by: Anton Kharuzhy <publicantroids@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[MQTT.Homeassistant] make the mqtt.vacuum compliant with the Specification
The mqtt.vacuum HA component has a Specification at https://www.home-assistant.io/integrations/vacuum.mqtt/
The goal of this PR is to make OpenHAB implementation compliant with the Specification, to be sure that any vacuum can be supported by Homeassistant integration out of the box.
I added support for legacy schema and all missing configuration attributes.
Unfortunately, time and usage status attributes are out of specification and they are specific for old valetudo versions only. So, I removed them from implementation. The new valetudo firmware should be supported by Homie binding. Any firmware specific mqtt messages can also be handled by generic mqtt binding.