[myq] Fixes breaking API changes to the MyQ binding #11601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/chamberlain-myq-binding/4192/792 |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
The PR builds are failing because this add-on bundle is missing from the add-ons BOM, which should be fixed with #11605. |
|
thanks @wborn ! Did i forget to add that when this binding was first submitted? Yikes. 😱 |
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
digitaldan
changed the title
wborn
requested changes
Nov 19, 2021
There was a problem hiding this comment.
Thanks for the fixes @digitaldan! The code looks good but I think there are a couple of typos.
...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java
Outdated
Show resolved
Hide resolved
...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java
Outdated
Show resolved
Hide resolved
...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java
Outdated
Show resolved
Hide resolved
...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java
Outdated
Show resolved
Hide resolved
...ab.binding.myq/src/main/java/org/openhab/binding/myq/internal/handler/MyQAccountHandler.java
Outdated
Show resolved
Hide resolved
wborn
added
bug
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
|
Thanks @wborn , i really copied and pasted the heck out of that typo ! That should be fixed now. |
wborn
approved these changes
Nov 19, 2021
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
Signed-off-by: Dan Cunningham <dan@digitaldan.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
Signed-off-by: Dan Cunningham <dan@digitaldan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Cunningham dan@digitaldan.com