Bump jsoup from 1.8.3 to 1.14.3 #11643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version instaed of compile time dependency. Signed-off-by: Sönke Küper <soenkekueper@gmx.de>
soenkekueper
requested review from
clinique,
cschneider,
digitaldan,
jochen314,
kgoderis,
lolodomo and
Skinah
as code owners
fwolter
approved these changes
Nov 27, 2021
There was a problem hiding this comment.
LGTM
@clinique, @cschneider, @digitaldan, @jochen314, @kgoderis, @lolodomo, @Skinah Can you please test if 1.14.3 behaves as you'd expect it with your code? The update is necessary due to a security issue. See https://jsoup.org/news/release-1.14.2
fwolter
added
the
additional testing preferred
|
It works in the ipobserver binding so all good here. However just a suggestion that if there are this many addons all using the same dependency, can it be change like in this PR so changing the version in the future only needs to be done in one line and in one file? From then on it is just the main pom that needs the version to be changed and all the bindings will follow. |
wborn
added
bug
fwolter
approved these changes
Dec 11, 2021
|
@clinique, @cschneider, @digitaldan, @jochen314, @kgoderis, @lolodomo Your binding will use the new jsoup version from OH 3.2.0.RC1 on. Please test your binding, if this update doesn't break anything. 3.2.0.RC1 will be released on Friday, December 17. |
|
no problems here. |
wborn
removed
the
additional testing preferred
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…version instaed of compile time dependency. (openhab#11643) Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Co-authored-by: Sönke Küper <soenkekueper@gmx.de> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…version instaed of compile time dependency. (openhab#11643) Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Co-authored-by: Sönke Küper <soenkekueper@gmx.de> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…version instaed of compile time dependency. (openhab#11643) Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Co-authored-by: Sönke Küper <soenkekueper@gmx.de>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
…version instaed of compile time dependency. (openhab#11643) Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Co-authored-by: Sönke Küper <soenkekueper@gmx.de>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…version instaed of compile time dependency. (openhab#11643) Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Co-authored-by: Sönke Küper <soenkekueper@gmx.de>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…version instaed of compile time dependency. (openhab#11643) Signed-off-by: Sönke Küper <soenkekueper@gmx.de> Co-authored-by: Sönke Küper <soenkekueper@gmx.de> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the jsoup library from 1.8.3 to 1.14.3.
#11615 was created by dependabot, but the 1.14.2 has an OSGI dependency error (see https://jsoup.org/news/release-1.14.3),
so i've used the 1.14.3.
Due some build errors in several plugins i've updated all of them to use the osgi provided bundle instead of compile time dependency.
I've placed all of the plugins within my local test installation, after manual installation of required bundles all of them were installed and started successfully.