-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[androiddebugbridge] Add channels for record events, open urls and doc improvements #11692
Merged
lolodomo
merged 8 commits into
openhab:main
from
GiviMAD:androiddebugbinding/input_events
Dec 20, 2021
Merged
[androiddebugbridge] Add channels for record events, open urls and doc improvements #11692
lolodomo
merged 8 commits into
openhab:main
from
GiviMAD:androiddebugbinding/input_events
Dec 20, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
cweitkamp
added
the
enhancement
An enhancement or new feature for an existing add-on
label
Dec 4, 2021
lolodomo
requested changes
Dec 7, 2021
bundles/org.openhab.binding.androiddebugbridge/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
lolodomo
requested changes
Dec 9, 2021
.../src/main/java/org/openhab/binding/androiddebugbridge/internal/AndroidDebugBridgeDevice.java
Outdated
Show resolved
Hide resolved
...src/main/java/org/openhab/binding/androiddebugbridge/internal/AndroidDebugBridgeHandler.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.binding.androiddebugbridge/src/main/resources/OH-INF/thing/thing-types.xml
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
lolodomo
requested changes
Dec 17, 2021
...src/main/java/org/openhab/binding/androiddebugbridge/internal/AndroidDebugBridgeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
GiviMAD
force-pushed
the
androiddebugbinding/input_events
branch
from
December 17, 2021 20:06
5d97306
to
de006ff
Compare
lolodomo
approved these changes
Dec 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@GiviMAD : really sorry for the delay I needed to understand your strange code to delete a thing property. Unfortunately I can't merge this PR until 3.2 is released, except if @kaikreuzer accepts a derogation. |
mherwege
pushed a commit
to mherwege/openhab-addons
that referenced
this pull request
Dec 23, 2021
…c improvements (openhab#11692) * Add channels for record events, open urls and doc improvements Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
NickWaterton
pushed a commit
to NickWaterton/openhab-addons
that referenced
this pull request
Dec 30, 2021
…c improvements (openhab#11692) * Add channels for record events, open urls and doc improvements Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83
pushed a commit
to mischmidt83/openhab-addons
that referenced
this pull request
Jan 9, 2022
…c improvements (openhab#11692) * Add channels for record events, open urls and doc improvements Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud
pushed a commit
to nemerdaud/openhab-addons
that referenced
this pull request
Jan 28, 2022
…c improvements (openhab#11692) * Add channels for record events, open urls and doc improvements Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
andan67
pushed a commit
to andan67/openhab-addons
that referenced
this pull request
Nov 6, 2022
…c improvements (openhab#11692) * Add channels for record events, open urls and doc improvements Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com>
andrasU
pushed a commit
to andrasU/openhab-addons
that referenced
this pull request
Nov 12, 2022
…c improvements (openhab#11692) * Add channels for record events, open urls and doc improvements Signed-off-by: Miguel Álvarez Díez <miguelwork92@gmail.com> Signed-off-by: Andras Uhrin <andras.uhrin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Miguel Álvarez Díez miguelwork92@gmail.com
Minor additions for the androiddebugbridge binding: